Skip to content

Conversation

@dalbhanj
Copy link
Contributor

@dalbhanj dalbhanj commented Nov 9, 2022

Issue aws-controllers-k8s/community#1489

Description of changes: Kubectl can show state changes of jobruns

  • Add Status.State field
  • Add kubebuilder columns to support printing State and ID when calling kubectl get

Example output:

$ kubectl get jobruns -w
NAME               JOB-ID                STATE
my-ack-jobrun-01   0000000312np262is2t   FAILED
my-ack-jobrun-02   0000000312nrulbojo3   COMPLETED
my-ack-jobrun-03   0000000312t1q0qonkc   COMPLETED
my-ack-jobrun-04   0000000312uesu2s8cu   COMPLETED
my-ack-jobrun-05   0000000312uhf8rs910   COMPLETED

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@a-hilaly a-hilaly changed the title adding jobrun state Add JobRun state field Nov 9, 2022
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
+++

@ack-bot ack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 9, 2022
@a-hilaly
Copy link
Member

@dalbhanj can you try regenerating with code-generator 5ee0ac052c54f008dff50f6f5ebb73f2cf3a0bd7 instead? looks like we lost few helm features in this PR.

@dalbhanj
Copy link
Contributor Author

@dalbhanj can you try regenerating with code-generator 5ee0ac052c54f008dff50f6f5ebb73f2cf3a0bd7 instead? looks like we lost few helm features in this PR.

Done

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2022
@ack-bot ack-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2022
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/unhold

@ack-bot ack-bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 11, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Nov 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, dalbhanj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit ef7030b into aws-controllers-k8s:main Nov 11, 2022
@dalbhanj dalbhanj deleted the job-state branch November 11, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants