Skip to content

Conversation

@ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Nov 23, 2025

Update to ACK runtime v0.54.1, code-generator v0.54.0



NOTE:
This PR increments the release version of service controller from v1.1.2 to v1.1.3

Once this PR is merged, release v1.1.3 will be automatically created for eventbridge-controller

Please close this PR, if you do not want the new patch release for eventbridge-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building eventbridge-controller ====
Copying common custom resource definitions into eventbridge
Building Kubernetes API objects for eventbridge
Generating deepcopy code for eventbridge
Generating custom resource definitions for eventbridge
Building service controller for eventbridge
Running GO mod tidy
Generating RBAC manifests for eventbridge
Running gofmt against generated code for eventbridge
Updating additional GitHub repository maintenance files
==== building eventbridge-controller release artifacts ====
Building release artifacts for eventbridge-v1.1.3
Generating common custom resource definitions
Generating custom resource definitions for eventbridge
Generating RBAC manifests for eventbridge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Nov 23, 2025
@ack-prow
Copy link

ack-prow bot commented Nov 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ack-bot
Once this PR has been reviewed and has the lgtm label, please assign a-hilaly for approval by writing /assign @a-hilaly in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot requested review from a-hilaly and michaelhtm November 23, 2025 08:47

jobs:
call-hydrate-go-proxy:
uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 3 days ago

To fix the code, you should explicitly set a permissions block for this workflow to restrict default permissions for the GITHUB_TOKEN. The best practice is to add this at the top level of the workflow file unless individual jobs need different permissions. Since the only job present is a "workflow call" that doesn't specify, the best place is at the root (above jobs:), using the least privilege starting point (permissions: {})—this sets all permissions to read-only and is a safe default. If in the future the workflow or any included actions require specific permissions, they can be loosened as needed. The edit is to insert the block:

permissions: {}

After the name: ... block, before on:.

Suggested changeset 1
.github/workflows/postsubmit.yaml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/postsubmit.yaml b/.github/workflows/postsubmit.yaml
--- a/.github/workflows/postsubmit.yaml
+++ b/.github/workflows/postsubmit.yaml
@@ -1,4 +1,5 @@
 name: Hydrate Go Proxy
+permissions: {}
 
 on:
   push:
EOF
@@ -1,4 +1,5 @@
name: Hydrate Go Proxy
permissions: {}

on:
push:
Copilot is powered by AI and may make mistakes. Always verify output.
@ack-prow
Copy link

ack-prow bot commented Nov 23, 2025

@ack-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
eventbridge-verify-code-gen 145921f link false /test eventbridge-verify-code-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

prow/auto-gen PRs related to prow auto generation automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant