-
Notifications
You must be signed in to change notification settings - Fork 41
Update to ACK runtime v0.54.1, code-generator v0.54.0
#164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| jobs: | ||
| call-hydrate-go-proxy: | ||
| uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 1 day ago
The best way to fix this problem is to add an explicit permissions key to the workflow at the root level, with the minimal set of permissions required. Since the delegate job simply calls a reusable workflow, it is safest to set a restrictive default policy (such as contents: read). If the job or reusable workflow requires more permissions, those can be added specifically. For this example, adding the block:
permissions:
contents: readimmediately after the name: line (and before on:) in .github/workflows/postsubmit.yaml is the correct approach. This change does not affect any existing workflow logic or outputs.
-
Copy modified lines R2-R3
| @@ -1,4 +1,6 @@ | ||
| name: Hydrate Go Proxy | ||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| push: |
|
@ack-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ack-bot, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update to ACK runtime
v0.54.1, code-generatorv0.54.0v0.54.0release notesv0.54.1release notesNOTE:
This PR increments the release version of service controller from
v1.5.3tov1.5.4Once this PR is merged, release
v1.5.4will be automatically created foriam-controllerPlease close this PR, if you do not want the new patch release for
iam-controllerstdout for
make build-controller:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.