Skip to content

Conversation

@michaelhtm
Copy link
Member

@michaelhtm michaelhtm commented Nov 24, 2025

Description of changes:
Currently, after a role is created, we set the synced condition to
false, causing the controller to requeue the resource and process any
updates in 30 seconds (default requeue on non synced resource)

This is not an ideal use case for users who have thousands of resources,
and don't want to wait long for their resources to be processed/ready.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Currently, after a role is created, we set the synced condition to
false, casuing the controller to requeue the resource and proccess any
updates in 30 seconds (default requeue on non synced resource)

This is not an ideal use case for users who have thousands of resources,
and don't want to wait long for their resources to be processed/ready.
@ack-prow ack-prow bot requested review from a-hilaly and knottnt November 24, 2025 02:13
@ack-prow ack-prow bot added the approved label Nov 24, 2025
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2025
@ack-prow
Copy link

ack-prow bot commented Nov 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,michaelhtm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow
Copy link

ack-prow bot commented Nov 24, 2025

@michaelhtm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
iam-verify-attribution ff5f940 link false /test iam-verify-attribution
iam-verify-code-gen ff5f940 link false /test iam-verify-code-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ack-prow ack-prow bot merged commit 802ed34 into aws-controllers-k8s:main Nov 24, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants