Skip to content

Conversation

ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Sep 19, 2025

Update to ACK runtime v0.52.0, code-generator v0.52.0



NOTE:
This PR increments the release version of service controller from v1.2.0 to v1.2.1

Once this PR is merged, release v1.2.1 will be automatically created for kafka-controller

Please close this PR, if you do not want the new patch release for kafka-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building kafka-controller ====
Copying common custom resource definitions into kafka
Building Kubernetes API objects for kafka
Generating deepcopy code for kafka
Generating custom resource definitions for kafka
Building service controller for kafka
Running GO mod tidy
Generating RBAC manifests for kafka
Running gofmt against generated code for kafka
Updating additional GitHub repository maintenance files
==== building kafka-controller release artifacts ====
Building release artifacts for kafka-v1.2.1
Generating common custom resource definitions
Generating custom resource definitions for kafka
Generating RBAC manifests for kafka

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Sep 19, 2025
@ack-prow ack-prow bot requested a review from michaelhtm September 19, 2025 16:54
Copy link

ack-prow bot commented Sep 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ack-bot
Once this PR has been reviewed and has the lgtm label, please assign jlbutler for approval by writing /assign @jlbutler in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot requested a review from rushmash91 September 19, 2025 16:54
@knottnt
Copy link
Contributor

knottnt commented Sep 19, 2025

/test kafka-kind-e2e

Copy link
Contributor

@knottnt knottnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2025
@knottnt
Copy link
Contributor

knottnt commented Sep 19, 2025

/test kafka-kind-e2e

3 similar comments
@knottnt
Copy link
Contributor

knottnt commented Sep 19, 2025

/test kafka-kind-e2e

@knottnt
Copy link
Contributor

knottnt commented Sep 20, 2025

/test kafka-kind-e2e

@knottnt
Copy link
Contributor

knottnt commented Sep 20, 2025

/test kafka-kind-e2e

Copy link

ack-prow bot commented Sep 20, 2025

@ack-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kafka-verify-attribution 23d1019 link false /test kafka-verify-attribution
kafka-kind-e2e 23d1019 link true /test kafka-kind-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knottnt
Copy link
Contributor

knottnt commented Sep 22, 2025

/close

e2e test fixed in #78

@ack-prow ack-prow bot closed this Sep 22, 2025
Copy link

ack-prow bot commented Sep 22, 2025

@knottnt: Closed this PR.

In response to this:

/close

e2e test fixed in #78

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. prow/auto-gen PRs related to prow auto generation automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants