Skip to content

Conversation

@ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Nov 23, 2025

Update to ACK runtime v0.54.1, code-generator v0.54.0



NOTE:
This PR increments the release version of service controller from v1.6.3 to v1.6.4

Once this PR is merged, release v1.6.4 will be automatically created for rds-controller

Please close this PR, if you do not want the new patch release for rds-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building rds-controller ====
Copying common custom resource definitions into rds
Building Kubernetes API objects for rds
Generating deepcopy code for rds
Generating custom resource definitions for rds
Building service controller for rds
Running GO mod tidy
Generating RBAC manifests for rds
Running gofmt against generated code for rds
Updating additional GitHub repository maintenance files
==== building rds-controller release artifacts ====
Building release artifacts for rds-v1.6.4
Generating common custom resource definitions
Generating custom resource definitions for rds
Generating RBAC manifests for rds

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Nov 23, 2025
@ack-prow ack-prow bot requested review from a-hilaly and jlbutler November 23, 2025 09:12
@ack-prow
Copy link

ack-prow bot commented Nov 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ack-bot
Once this PR has been reviewed and has the lgtm label, please assign michaelhtm for approval by writing /assign @michaelhtm in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


jobs:
call-hydrate-go-proxy:
uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 3 days ago

To fix the problem, you should add a permissions key to the workflow file, either at the workflow root (so it applies to all jobs by default) or at the specific job level. For single-job workflows, both approaches are equivalent, but setting it at the root makes it more immediately visible. The minimal starting point is to set permissions: {} (which disables all GITHUB_TOKEN permissions), or specify only those permissions actually needed by the job or the reusable workflow it invokes. Unless you know more granular requirements, permissions: read-all (maps to contents: read) is a safe default that prevents unnecessary write permissions. Modify .github/workflows/postsubmit.yaml near the top, after the name: field and before the on: field, to add:

permissions:
  contents: read

Alternatively, if you know no permissions are needed at all, use permissions: {}. But contents: read is required by most workflows.

No external libraries or complex changes are needed -- just the addition of the permissions block.

Suggested changeset 1
.github/workflows/postsubmit.yaml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/postsubmit.yaml b/.github/workflows/postsubmit.yaml
--- a/.github/workflows/postsubmit.yaml
+++ b/.github/workflows/postsubmit.yaml
@@ -1,4 +1,6 @@
 name: Hydrate Go Proxy
+permissions:
+  contents: read
 
 on:
   push:
EOF
@@ -1,4 +1,6 @@
name: Hydrate Go Proxy
permissions:
contents: read

on:
push:
Copilot is powered by AI and may make mistakes. Always verify output.
@ack-prow
Copy link

ack-prow bot commented Nov 23, 2025

@ack-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
rds-verify-code-gen 2c30d9f link false /test rds-verify-code-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

prow/auto-gen PRs related to prow auto generation automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant