Skip to content

Conversation

@ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Jan 23, 2025

Update to ACK runtime v0.41.0, code-generator v0.41.0



NOTE:
This PR increments the release version of service controller from v0.0.19 to v0.0.20

Once this PR is merged, release v0.0.20 will be automatically created for route53-controller

Please close this PR, if you do not want the new patch release for route53-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building route53-controller ====
Copying common custom resource definitions into route53
Building Kubernetes API objects for route53
Generating deepcopy code for route53
Generating custom resource definitions for route53
Building service controller for route53
Generating RBAC manifests for route53
Running gofmt against generated code for route53
Updating additional GitHub repository maintenance files
==== building route53-controller release artifacts ====
Building release artifacts for route53-v0.0.20
Generating common custom resource definitions
Generating custom resource definitions for route53
Generating RBAC manifests for route53

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Jan 23, 2025
@ack-prow ack-prow bot requested a review from a-hilaly January 23, 2025 02:26
@ack-prow
Copy link

ack-prow bot commented Jan 23, 2025

@ack-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
route53-verify-attribution 3d4d42a link false /test route53-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@a-hilaly
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2025
@ack-prow
Copy link

ack-prow bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Jan 23, 2025
@ack-prow ack-prow bot merged commit f657f6e into main Jan 23, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged. prow/auto-gen PRs related to prow auto generation automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants