Skip to content

Conversation

@a-hilaly
Copy link
Member

Kubernetes 1.30 was released 6 days ago and ACK should follow :) - Bumping our client-go
k8s/apimachinery and controller-runtimes for a smooth ACK on 1.30 experience.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Amine Hilaly <hilalyamine@gmail.com>
@ack-prow ack-prow bot requested review from jlbutler and jljaco April 23, 2024 11:51
@ack-prow
Copy link

ack-prow bot commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Apr 23, 2024
@ack-prow
Copy link

ack-prow bot commented Apr 23, 2024

@a-hilaly: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
iam-controller-test 74a9f00 link true /test iam-controller-test
ecr-controller-test 74a9f00 link true /test ecr-controller-test
s3-controller-test 74a9f00 link true /test s3-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@a-hilaly a-hilaly closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant