Skip to content

Conversation

@a-hilaly
Copy link
Member

Add support for including the Kubernetes resource Kind in default tags through a new %K8S_RESOURCE_KIND% format placeholder.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Add support for including the Kubernetes resource Kind in default tags
through a new %K8S_RESOURCE_KIND% format placeholder.
@ack-prow ack-prow bot requested review from jlbutler and michaelhtm November 23, 2025 03:23
@ack-prow ack-prow bot added the approved label Nov 23, 2025
Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2025
@ack-prow
Copy link

ack-prow bot commented Nov 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,michaelhtm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@a-hilaly
Copy link
Member Author

/retest

@ack-prow
Copy link

ack-prow bot commented Nov 23, 2025

@a-hilaly: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
s3-controller-test 59e785e link true /test s3-controller-test
verify-attribution 59e785e link false /test verify-attribution
unit-test 59e785e link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@michaelhtm michaelhtm merged commit 628617a into aws-controllers-k8s:main Nov 23, 2025
3 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants