feat(runtime): add k8s-managed-by and kro version context to user agent and tags #215
Conversation
a-hilaly
changed the title
When resources are managed by KRO, ACK now includes KRO information in AWS API calls through user agent strings and resource tags. This makes it easier to understand which resources came from KRO when looking at AWS CloudTrail logs, cost allocation reports, and usage metrics. The implementation detects KRO managed resources via the standard Kubernetes `app.kubernetes.io/managed-by` label (with backward compatibility for the legacy `kro.run/owned` label), and adds optional `%MANAGED_BY%` and `%KRO_VERSION%` tag formats that can be used in default tags configuration. Empty tag values are automatically skipped to keep resources clean.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@a-hilaly: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test s3-controller-test |
2 participants
When resources are managed by KRO, ACK now includes KRO information in
AWS API calls through user agent strings and resource tags. This makes
it easier to understand which resources came from KRO when looking at
AWS CloudTrail logs, cost allocation reports, and usage metrics. The
implementation detects KRO managed resources via the standard Kubernetes
app.kubernetes.io/managed-bylabel (with backward compatibility for thelegacy
kro.run/ownedlabel), and adds optional%MANAGED_BY%and%KRO_VERSION%tag formats that can be used in default tags configuration.Empty tag values are automatically skipped to keep resources clean.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.