fix: add namespace cache fallback to IAMRoleSelector cache #216
Conversation
When the IAMRoleSelector feature is enabled, the IAMRoleSelector cache runs its own `NamespaceCache` to support namespace based matching. However, the reconciler's namespace lookup methods (`getDefaultRegion`, `getEndpointURL`, `getDeletionPolicy`) were only checking `carmCache.Namespaces`, causing these values to be unavailable when only the IAMRoleSelector cache was running. This change makes the `Namespaces` field public on the IAMRoleSelector cache and adds fallback logic in the reconciler to check `irsCache.Namespaces` when `carmCache.Namespaces` doesn't have the requested data, ensuring namespace annotations remain accessible regardless of which cache is active.
|
@a-hilaly: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
When the IAMRoleSelector feature is enabled, the IRS internal cache
runs its own
NamespaceCacheto support namespace based matching.However, the reconciler's namespace lookup methods (
getDefaultRegion,getEndpointURL,getDeletionPolicy) were only checkingcarmCache.Namespaces, causing these values to be unavailable when onlythe IAMRoleSelector cache was running. This change makes the
Namespacesfield public on the IAMRoleSelector cache and adds fallback logic in the
reconciler to check
irsCache.NamespaceswhencarmCache.Namespacesdoesn't have the requested data, ensuring namespace annotations remain
accessible regardless of which cache is active.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.