Skip to content

Conversation

@michaelhtm
Copy link
Member

Issue #2673

Description of changes:
With this change, ACK now ignores tags that are passed on startup.
On top of that it also valdidates ResourceTags on startup, instead of
doing so during reconcile.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from jlbutler and rushmash91 November 23, 2025 05:32
@ack-prow ack-prow bot added the approved label Nov 23, 2025
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ack-prow
Copy link

ack-prow bot commented Nov 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,michaelhtm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

With this change, ACK now ignores tags that are passed on startup.
On top of that it also valdidates ResourceTags on startup, instead of
doing so during reconcile.
@michaelhtm michaelhtm force-pushed the fix/ignoretagspassedonstart branch from 5ac3dfa to a196b41 Compare November 23, 2025 06:03
@ack-prow
Copy link

ack-prow bot commented Nov 23, 2025

@michaelhtm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-test 5ac3dfa link true /test unit-test
verify-attribution a196b41 link false /test verify-attribution
ecr-controller-test a196b41 link true /test ecr-controller-test
iam-controller-test a196b41 link true /test iam-controller-test
sagemaker-controller-test a196b41 link true /test sagemaker-controller-test
s3-controller-test a196b41 link true /test s3-controller-test
sqs-controller-test a196b41 link true /test sqs-controller-test
ec2-controller-test a196b41 link true /test ec2-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@a-hilaly a-hilaly merged commit 981220e into aws-controllers-k8s:main Nov 23, 2025
0 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants