-
Notifications
You must be signed in to change notification settings - Fork 180
Add conditional for starting adoption reconciler #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conditional for starting adoption reconciler #59
Conversation
|
@RedbackThomson Here are my test results from a Without Applying the Uninstalling the operator and leaving the I think this solves the issue and didn't see any problems with testing. If you would like something else tested please let me know. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RedbackThomson, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
) Issue #, if available: aws-controllers-k8s/community#1006 Description of changes: Use cluster introspection to determine whether the `AdoptedResource` CRD has been installed, starting the adoption reconciler only if they have been. This will allow cluster operators to intentionally leave the `AdoptedResource` uninstalled, if they wish to handle this separately. I have tested these changes by uninstalling the `AdoptedResource` CRD and then running the controller. I see the following line in the logs to prove it is working: ``` 2021-10-19T14:52:42.975-0700 INFO adoption AdoptedResource CRD not installed. The adoption reconciler will not be started ``` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue #, if available: aws-controllers-k8s/community#1006
Description of changes:
Use cluster introspection to determine whether the
AdoptedResourceCRD has been installed, starting the adoption reconciler only if they have been. This will allow cluster operators to intentionally leave theAdoptedResourceuninstalled, if they wish to handle this separately.I have tested these changes by uninstalling the
AdoptedResourceCRD and then running the controller. I see the following line in the logs to prove it is working:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.