clear conditions on loop start and ensure synced #61
Conversation
jaypipes
force-pushed
the
condition-handling
branch
from
0987c01 to
4ad6a41
Compare
This is the first patch that looks at cleaning up our handling of Condition objects for resources. We make a change to the common runtime to clear all Condition objects from the desired resource's Status.Conditions collection at the beginning of the reconciliation loop and add a deferred call to a function that ensures that an ACK.ResourceSynced condition has been placed on the resource if the resource manager has failed to add one. Future patches will add functionality to the code generator to allow programmatic control over when generated resource managers set ACK.ResourceSynced conditions on their resources. Issue: aws-controllers-k8s/community#1030 Signed-off-by: Jay Pipes <jaypipes@gmail.com>
jaypipes
force-pushed
the
condition-handling
branch
from
4ad6a41 to
a9d3815
Compare
|
/approve This looks good! But this still leaves individual resource managers to implement the |
Yup, exactly! see commit message :) |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaypipes, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
This is the first patch that looks at cleaning up our handling of
Condition objects for resources. We make a change to the common runtime
to clear all Condition objects from the desired resource's
Status.Conditions collection at the beginning of the reconciliation loop
and add a deferred call to a function that ensures that an
ACK.ResourceSynced condition has been placed on the resource if the
resource manager has failed to add one.
Future patches will add functionality to the code generator to allow
programmatic control over when generated resource managers set
ACK.ResourceSynced conditions on their resources.
Issue: aws-controllers-k8s/community#1030
Signed-off-by: Jay Pipes jaypipes@gmail.com
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.