Add IsSynced function to the AWSResourceManager interface
#67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vijtrip2
approved these changes
Jan 21, 2022
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, RedbackThomson, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jaypipes
changed the title
IsSynced function to the AWSResource interfaceIsSynced function to the AWSResourceManager interface
vijtrip2
added a commit
to vijtrip2/runtime
that referenced
this pull request
Jan 24, 2022
…ontrollers-k8s#67)" This reverts commit f142275.
a-hilaly
added a commit
to a-hilaly/ack-runtime
that referenced
this pull request
Jan 26, 2022
…rs-k8s#67) Follow up to aws-controllers-k8s/code-generator#247 Description of changes: - Add `IsSynced` function to the `AWSResource` interface By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
ack-bot
pushed a commit
that referenced
this pull request
Jan 26, 2022
Follow up to aws-controllers-k8s/code-generator#247 Description of changes: - Add `IsSynced` function to the `AWSResource` interface By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Issue #, if available: Description of changes: By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to aws-controllers-k8s/code-generator#247
Description of changes:
IsSyncedfunction to theAWSResourceManagerinterfaceBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.