Allow optional endpoint argument #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypipes
requested changes
Mar 3, 2021
There was a problem hiding this comment.
I think we should take advantage of the https://docs.aws.amazon.com/sdk-for-go/api/aws/endpoints/ module, including its ResolverFunc interface instead of manually parsing URLs in the startup of the controller.
In addition, we should be using the https://docs.aws.amazon.com/sdk-for-go/api/aws/endpoints/ module's Partition support instead of manually setting endpoint URLs if at all possible...
jaypipes
requested changes
Mar 16, 2021
Most AWS including ElastiCache allows customers to invoke APIs using FIPS endpoint. https://docs.aws.amazon.com/general/latest/gr/rande.html#FIPS-endpoints This commit introduces ability to specify endpoint URL like AWS CLI.
kumargauravsharma
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most AWS including ElastiCache allows customers to invoke APIs using FIPS
endpoint.
https://docs.aws.amazon.com/general/latest/gr/rande.html#FIPS-endpoints
This commit introduces ability to specify endpoint URL like AWS CLI.