handle requeues after setting Synced condition

[vijtrip2]

Issue: aws-controllers-k8s/community#1186

Description of changes:

• Call handleRequeues method after setting the ACK.ResourceSynced condition
• Use AWSResourceManager.IsSynced method to determine the ACK.ResourceSynced condition
• Only set ACK.ResourceSynced condition inside ensureConditions function when the condition is originally missing
• Update existing unit-tests to include rm.IsSynced() call and Add a new unit-test when rm.IsSynced returns false

---

• Also tested locally using Sagemaker controller, whose e2e tests verify that SyncedCondition is properly set in success and failure scenarios. This ensures there is no breakage in existing functionality.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[a-hilaly]

Sweet! Left few comments below

[a-hilaly]

LGTM overall. Great testing @vijtrip2
/approve

[jaypipes]

@vijtrip2 please separate this into two PRs, one for the code changes to call IsSynced in ensureConditions and another for the resource reference resolution bits. It's difficult to review this PR as it stands because these two code changes are unrelated to each other.

[RedbackThomson]

Just one question, otherwise good to go

[jaypipes]

Rock on, thanks for separating the PRs :)

[jaypipes]

/lgtm

[ack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, jaypipes, RedbackThomson, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [A-Hilaly,RedbackThomson,jaypipes,vijtrip2]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment