Skip to content

Update to ACK runtime v0.54.1, code-generator v0.54.0 #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2025
+1,180 −765
Merged

Update to ACK runtime v0.54.1, code-generator v0.54.0 #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/postsubmit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
name: Hydrate Go Proxy

on:
push:
branches:
- main

jobs:
call-hydrate-go-proxy:
uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 5 days ago

To address the issue, we should add a permissions block at the workflow level in .github/workflows/postsubmit.yaml, with minimal required permissions. Since the reusable workflow is being called via uses:, and unless there is evidence that it requires write permissions, we should use the least privilege principle. Typically, for workflows with no obvious write operations (such as publishing to contents or writing to issues/pull-requests), contents: read is an appropriate default. If later analysis shows that write access is needed for some scopes, those can be added. The permissions block should be inserted at the root level immediately below the name and before any on/jobs blocks.

Suggested changeset 1
.github/workflows/postsubmit.yaml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/postsubmit.yaml b/.github/workflows/postsubmit.yaml
--- a/.github/workflows/postsubmit.yaml
+++ b/.github/workflows/postsubmit.yaml
@@ -1,4 +1,6 @@
 name: Hydrate Go Proxy
+permissions:
+  contents: read
 
 on:
   push:
EOF
@@ -1,4 +1,6 @@
name: Hydrate Go Proxy
permissions:
contents: read

on:
push:
Copilot is powered by AI and may make mistakes. Always verify output.
1,869 changes: 1,129 additions & 740 deletions ATTRIBUTION.md
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions apis/v1alpha1/ack-generate-metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
ack_generate_info:
build_date: "2025-11-12T22:47:47Z"
build_hash: c833f2d14f4fe8953663ff92f4661ae5fb01b8c8
build_date: "2025-11-23T08:49:49Z"
build_hash: e922bb8587f26eeed72a531e5d92389b81e8b55b
go_version: go1.25.4
version: v0.53.1
version: v0.54.0
api_directory_checksum: 2108338a86d704419192e545c0bfb433bab8c836
api_version: v1alpha1
aws_sdk_go_version: v1.32.6
Expand Down
2 changes: 1 addition & 1 deletion config/controller/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ kind: Kustomization
images:
- name: controller
newName: public.ecr.aws/aws-controllers-k8s/s3-controller
newTag: 1.1.2
newTag: 1.1.3
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ go 1.24.0
toolchain go1.24.1

require (
github.com/aws-controllers-k8s/runtime v0.53.1
github.com/aws-controllers-k8s/runtime v0.54.1
github.com/aws/aws-sdk-go v1.49.0
github.com/aws/aws-sdk-go-v2 v1.34.0
github.com/aws/aws-sdk-go-v2/service/s3 v1.74.1
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
github.com/aws-controllers-k8s/runtime v0.53.1 h1:l9MkR1KfZW8H8icT5rrRK3pdnVVA4io/eINVe5aspWs=
github.com/aws-controllers-k8s/runtime v0.53.1/go.mod h1:OkUJN+Ds799JLYZsMJrO2vDJ4snxUeHK2MgrQHbU+Qc=
github.com/aws-controllers-k8s/runtime v0.54.1 h1:0mbCJELz3t7jbG4abNecF0yeRd8YeFZQPr7nnzr8DC8=
github.com/aws-controllers-k8s/runtime v0.54.1/go.mod h1:OkUJN+Ds799JLYZsMJrO2vDJ4snxUeHK2MgrQHbU+Qc=
github.com/aws/aws-sdk-go v1.49.0 h1:g9BkW1fo9GqKfwg2+zCD+TW/D36Ux+vtfJ8guF4AYmY=
github.com/aws/aws-sdk-go v1.49.0/go.mod h1:LF8svs817+Nz+DmiMQKTO3ubZ/6IaTpq3TjupRn3Eqk=
github.com/aws/aws-sdk-go-v2 v1.34.0 h1:9iyL+cjifckRGEVpRKZP3eIxVlL06Qk1Tk13vreaVQU=
Expand Down
4 changes: 2 additions & 2 deletions helm/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
apiVersion: v1
name: s3-chart
description: A Helm chart for the ACK service controller for Amazon Simple Storage Service (S3)
version: 1.1.2
appVersion: 1.1.2
version: 1.1.3
appVersion: 1.1.3
home: https://github.com/aws-controllers-k8s/s3-controller
icon: https://raw.githubusercontent.com/aws/eks-charts/master/docs/logo/aws.png
sources:
Expand Down
2 changes: 1 addition & 1 deletion helm/templates/NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{ .Chart.Name }} has been installed.
This chart deploys "public.ecr.aws/aws-controllers-k8s/s3-controller:1.1.2".
This chart deploys "public.ecr.aws/aws-controllers-k8s/s3-controller:1.1.3".

Check its status by running:
kubectl --namespace {{ .Release.Namespace }} get pods -l "app.kubernetes.io/instance={{ .Release.Name }}"
Expand Down
5 changes: 4 additions & 1 deletion helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

image:
repository: public.ecr.aws/aws-controllers-k8s/s3-controller
tag: 1.1.2
tag: 1.1.3
pullPolicy: IfNotPresent
pullSecrets: []

Expand Down Expand Up @@ -120,8 +120,11 @@ watchSelectors: ""
resourceTags:
# Configures the ACK service controller to always set key/value pairs tags on
# resources that it manages.
# Note: Tags with empty values are automatically skipped to keep resources clean.
- services.k8s.aws/controller-version=%CONTROLLER_SERVICE%-%CONTROLLER_VERSION%
- services.k8s.aws/namespace=%K8S_NAMESPACE%
- app.kubernetes.io/managed-by=%MANAGED_BY%
- kro.run/kro-version=%KRO_VERSION%

# Set to "retain" to keep all AWS resources intact even after the K8s resources
# have been deleted. By default, the ACK controller will delete the AWS resource
Expand Down
29 changes: 21 additions & 8 deletions pkg/resource/bucket/manager.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions pkg/resource/bucket/tags.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading