Skip to content

Conversation

@surajkota
Copy link
Contributor

  • install/uninstall crds separately since helm uninstall does not delete crds
    • there are GitHub issues indicating its meant to be managed separately
  • bug fixes to canary scripts

Testing

using codebuild

@surajkota surajkota requested review from akartsky and mbaijal May 11, 2021 04:49
@surajkota surajkota self-assigned this May 11, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented May 11, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akartsky, surajkota

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaypipes jaypipes merged commit 87d1501 into aws-controllers-k8s:main May 11, 2021
ryansteakley pushed a commit to ryansteakley/sagemaker-controller that referenced this pull request May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants