Update runtime to 0.2.0 which includes Namespace scope feature #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajkota
reviewed
May 14, 2021
go.sum
Outdated
| github.com/asaskevich/govalidator v0.0.0-20180720115003-f9ffefc3facf/go.mod h1:lB+ZfQJz7igIIfQNfa7Ml4HSf2uFQQRzpGGRXenZAgY= | ||
| github.com/asaskevich/govalidator v0.0.0-20190424111038-f61b66f89f4a/go.mod h1:lB+ZfQJz7igIIfQNfa7Ml4HSf2uFQQRzpGGRXenZAgY= | ||
| github.com/aws-controllers-k8s/runtime v0.1.2 h1:prqFY6tlmgsGMZizHvHqDqT1zECRqllepqplOHet4D4= | ||
| github.com/aws-controllers-k8s/runtime v0.1.2/go.mod h1:xA2F18PJerBHaqrS4de1lpP7skeSMeStkmh+3x5sWvw= |
Contributor
|
could you add testing info to pr description |
mbaijal
approved these changes
May 18, 2021
surajkota
approved these changes
May 18, 2021
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akartsky, mbaijal, surajkota The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/lgtm |
ryansteakley
pushed a commit
to ryansteakley/sagemaker-controller
that referenced
this pull request
May 18, 2021
…ontrollers-k8s#30) * Update runtime to 0.2.0 which includes Namespace scope feature * go mod tidy Add samples for each CRD Update README
ryansteakley
pushed a commit
to ryansteakley/sagemaker-controller
that referenced
this pull request
May 19, 2021
…ontrollers-k8s#30) * Update runtime to 0.2.0 which includes Namespace scope feature * go mod tidy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update runtime to 0.2.0 which includes Namespace scope feature
tested positive and negative case for namespace locally