Skip to content

Conversation

@ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Nov 12, 2025

Update to ACK runtime v0.53.1, code-generator v0.53.1



NOTE:
This PR increments the release version of service controller from v1.5.0 to v1.5.1

Once this PR is merged, release v1.5.1 will be automatically created for sagemaker-controller

Please close this PR, if you do not want the new patch release for sagemaker-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building sagemaker-controller ====
Copying common custom resource definitions into sagemaker
Building Kubernetes API objects for sagemaker
Generating deepcopy code for sagemaker
Generating custom resource definitions for sagemaker
Building service controller for sagemaker
Running GO mod tidy
Generating RBAC manifests for sagemaker
Running gofmt against generated code for sagemaker
Updating additional GitHub repository maintenance files
==== building sagemaker-controller release artifacts ====
Building release artifacts for sagemaker-v1.5.1
Generating common custom resource definitions
Generating custom resource definitions for sagemaker
Generating RBAC manifests for sagemaker

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Nov 12, 2025
@ack-prow ack-prow bot requested review from ananth102 and sirutBuasai November 12, 2025 22:34
@michaelhtm
Copy link
Member

/hold

@ack-prow ack-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2025
@michaelhtm michaelhtm force-pushed the ack-bot/rt-v0.53.1-codegen-v0.53.1 branch from 9c468a0 to 4d7159d Compare November 13, 2025 00:35
Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added lgtm Indicates that a PR is ready to be merged. approved labels Nov 13, 2025
@ack-prow
Copy link

ack-prow bot commented Nov 13, 2025

@ack-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
sagemaker-verify-code-gen 4d7159d link false /test sagemaker-verify-code-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/unhold

@ack-prow ack-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2025
@ack-prow
Copy link

ack-prow bot commented Nov 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ack-bot, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit f366646 into main Nov 13, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged. prow/auto-gen PRs related to prow auto generation automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants