Skip to content

Conversation

@a-hilaly
Copy link
Member

Fixes aws-controllers-k8s/community#1806

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from RedbackThomson and vijtrip2 May 20, 2023 02:22
@ack-prow ack-prow bot added the approved label May 20, 2023
Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks @a-hilaly!

@jaypipes
Copy link
Collaborator

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2023
@ack-prow ack-prow bot merged commit ad2521d into aws-controllers-k8s:main May 20, 2023
- name: controller
newName: public.ecr.aws/aws-controllers-k8s/sqs-controller
newTag: 1.0.3
newTag: 1.0.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, @a-hilaly you will need to rebase and correct this. Should not be going backwards by a version. :)

@ack-prow
Copy link

ack-prow bot commented May 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support redriveAllowPolicy for SQS DeadLetterQueues

2 participants