Skip to content

test: iam role selector #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 13, 2025
Merged

test: iam role selector #90

merged 2 commits into from
Nov 13, 2025

Conversation

@michaelhtm
Copy link
Member

@michaelhtm michaelhtm commented Nov 11, 2025

Description of changes:
add test for iam role selector

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and jlbutler November 11, 2025 01:30
@ack-prow ack-prow bot added the approved label Nov 11, 2025
@michaelhtm michaelhtm force-pushed the test/iamroleselector branch 4 times, most recently from b987c73 to b174350 Compare November 11, 2025 02:06
@michaelhtm
Copy link
Member Author

michaelhtm commented Nov 11, 2025

/test sqs-kind-e2e

@michaelhtm michaelhtm force-pushed the test/iamroleselector branch 3 times, most recently from 0fd5a70 to 7addc8b Compare November 11, 2025 02:46
@michaelhtm
Copy link
Member Author

michaelhtm commented Nov 11, 2025

/test sqs-kind-e2e

1 similar comment
@michaelhtm
Copy link
Member Author

michaelhtm commented Nov 11, 2025

/test sqs-kind-e2e

@michaelhtm michaelhtm force-pushed the test/iamroleselector branch 5 times, most recently from 8f3f6b5 to b71740f Compare November 11, 2025 19:17
@michaelhtm
Copy link
Member Author

michaelhtm commented Nov 11, 2025

/test sqs-kind-e2e

@michaelhtm michaelhtm force-pushed the test/iamroleselector branch 4 times, most recently from 88cfb48 to b262366 Compare November 11, 2025 20:22
@michaelhtm
test: iam role selector
848dc0c 
add test for iam role selector
@michaelhtm
Copy link
Member Author

michaelhtm commented Nov 11, 2025

/test sqs-kind-e2e

2 similar comments
@michaelhtm
Copy link
Member Author

michaelhtm commented Nov 11, 2025

/test sqs-kind-e2e

@michaelhtm
Copy link
Member Author

michaelhtm commented Nov 11, 2025

/test sqs-kind-e2e

@michaelhtm
Copy link
Member Author

michaelhtm commented Nov 11, 2025

/hold

@ack-prow ack-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2025
a-hilaly
a-hilaly reviewed Nov 12, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michaelhtm !

test/e2e/tests/test_queue_irs.py Outdated

time.sleep(CREATE_WAIT_AFTER_SECONDS)

assert k8s.wait_on_condition(ref, "ACK.ResourceSynced", "True", wait_periods=5)
Copy link
Member

@a-hilaly a-hilaly Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's wait on the IAMRoleSelector condition, and also Ready one?

Copy link
Member

@a-hilaly a-hilaly Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be great to have a test when two IRSs match

Copy link
Member Author

@michaelhtm michaelhtm Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an issue where we can't patch the resource status if there's an IRS conflict.
aws-controllers-k8s/community#2682
We can add these tests once that issue is fixed

@michaelhtm michaelhtm force-pushed the test/iamroleselector branch 3 times, most recently from 4e3219e to b495830 Compare November 12, 2025 23:25
@ack-prow
Copy link

ack-prow bot commented Nov 13, 2025

@michaelhtm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
sqs-verify-code-gen b495830 link false /test sqs-verify-code-gen
sqs-verify-attribution 54d9a0e link false /test sqs-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

a-hilaly
a-hilaly approved these changes Nov 13, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2025
@ack-prow
Copy link

ack-prow bot commented Nov 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,michaelhtm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michaelhtm
Copy link
Member Author

michaelhtm commented Nov 13, 2025

/unhold

@ack-prow ack-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2025
@ack-prow ack-prow bot merged commit 2308bc1 into aws-controllers-k8s:main Nov 13, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

@jlbutler jlbutler Awaiting requested review from jlbutler

Assignees

@a-hilaly a-hilaly

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelhtm @a-hilaly