fix e2e test to work in release branches #1253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeina2z
previously approved these changes
Oct 29, 2025
wangzlei
previously approved these changes
Oct 29, 2025
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1253 +/- ##
=============================================
- Coverage 85.71% 67.28% -18.43%
- Complexity 19 525 +506
=============================================
Files 3 54 +51
Lines 49 2693 +2644
Branches 5 373 +368
=============================================
+ Hits 42 1812 +1770
- Misses 3 746 +743
- Partials 4 135 +131 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lukeina2z
reviewed
Oct 29, 2025
lukeina2z
previously approved these changes
Oct 29, 2025
This reverts commit 49f2ce1.
|
Changes look good to me. The PR description seems outdated.
|
srprash
approved these changes
Oct 30, 2025
ezhang6811
added a commit
to ezhang6811/aws-otel-java-instrumentation
that referenced
this pull request
Oct 30, 2025
*Issue #, if available:* *Description of changes:* The workflow `application-signals-e2e-test.yml` assumes the version contains -SNAPSHOT. In release branches, we update `version.gradle.kts` to drop the -SNAPSHOT suffix to prepare for the release, so `upload-main-build` fails. See https://github.com/aws-observability/aws-otel-java-instrumentation/actions/runs/18921541300/job/54022142576 This PR modifies the job to match any artifact with the name `aws-opentelemetry-agent-*.jar`, with or without the SNAPSHOT suffix. tested by manually triggering main build in this branch: 1. adotVersion = 2.20.0-SNAPSHOT: https://github.com/aws-observability/aws-otel-java-instrumentation/actions/runs/18925772853/job/54034432606 `upload: ./aws-opentelemetry-agent-2.20.0-SNAPSHOT.jar to s3://adot-main-build-staging-jar/aws-opentelemetry-agent.jar` 2. adotVersion = 2.20.0: https://github.com/aws-observability/aws-otel-java-instrumentation/actions/runs/18927001060 `upload: ./aws-opentelemetry-agent-2.20.0.jar to s3://adot-main-build-staging-jar/aws-opentelemetry-agent.jar` Both runs are successful. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
ezhang6811
added a commit
that referenced
this pull request
Oct 30, 2025
*Issue #, if available:* *Description of changes:* The workflow `application-signals-e2e-test.yml` assumes the version contains -SNAPSHOT. In release branches, we update `version.gradle.kts` to drop the -SNAPSHOT suffix to prepare for the release, so `upload-main-build` fails. See https://github.com/aws-observability/aws-otel-java-instrumentation/actions/runs/18921541300/job/54022142576 This PR modifies the job to match any artifact with the name `aws-opentelemetry-agent-*.jar`, with or without the SNAPSHOT suffix. tested by manually triggering main build in this branch: 1. adotVersion = 2.20.0-SNAPSHOT: https://github.com/aws-observability/aws-otel-java-instrumentation/actions/runs/18925772853/job/54034432606 `upload: ./aws-opentelemetry-agent-2.20.0-SNAPSHOT.jar to s3://adot-main-build-staging-jar/aws-opentelemetry-agent.jar` 2. adotVersion = 2.20.0: https://github.com/aws-observability/aws-otel-java-instrumentation/actions/runs/18927001060 `upload: ./aws-opentelemetry-agent-2.20.0.jar to s3://adot-main-build-staging-jar/aws-opentelemetry-agent.jar` Both runs are successful. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. *Issue #, if available:* *Description of changes:* By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The workflow
application-signals-e2e-test.ymlassumes the version contains -SNAPSHOT. In release branches, we updateversion.gradle.ktsto drop the -SNAPSHOT suffix to prepare for the release, soupload-main-buildfails. See https://github.com/aws-observability/aws-otel-java-instrumentation/actions/runs/18921541300/job/54022142576This PR modifies the job to match any artifact with the name
aws-opentelemetry-agent-*.jar, with or without the SNAPSHOT suffix.tested by manually triggering main build in this branch:
upload: ./aws-opentelemetry-agent-2.20.0-SNAPSHOT.jar to s3://adot-main-build-staging-jar/aws-opentelemetry-agent.jarupload: ./aws-opentelemetry-agent-2.20.0.jar to s3://adot-main-build-staging-jar/aws-opentelemetry-agent.jarBoth runs are successful.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.