Skip to content

Conversation

@amirkaws
Copy link
Contributor

@amirkaws amirkaws commented Nov 29, 2021

Implemented bellow:

  • AOP mechanism to inject wrappers on compile based on aspect-injector
  • Core functionalities such as configuration
  • Core functionality unit tests
  • Tracing Attribute implementation
  • Tracing Attribute unit tests
  • It includes capturing ColdStart & Service annotations

Copy link
Contributor

@t1agob t1agob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all changes submitted and approve not only the tracing bits but the reusable code in AWS.Lambda.Powertools. Once this is merged will update the code on Metrics to use it.

@amirkaws amirkaws merged commit 8d2db20 into develop Dec 2, 2021
@amirkaws amirkaws deleted the amirkaws/tracing-1 branch December 2, 2021 09:30
@t1agob t1agob added area/tracing Core tracing utility enhancement labels Jan 18, 2022
@t1agob t1agob changed the title amirkaws/tracing 1 improv: amirkaws/tracing 1 Jan 18, 2022
@t1agob t1agob changed the title improv: amirkaws/tracing 1 feat: amirkaws/tracing 1 Jan 18, 2022
@t1agob t1agob changed the title feat: amirkaws/tracing 1 feat: added AOP support for tracing Jan 18, 2022
@t1agob t1agob added feature New features or minor changes and removed enhancement labels Jan 18, 2022
@t1agob t1agob changed the title feat: added AOP support for tracing feat: Initial tracing implementation Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tracing Core tracing utility feature New features or minor changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants