Skip to content

Conversation

@hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Jan 13, 2025

Please provide the issue number

Issue number: #685

Summary

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Signed-off-by: Henrique Graca <999396+hjgraca@users.noreply.github.com>
@auto-assign auto-assign bot requested review from amirkaws and sliedig January 13, 2025 15:12
@boring-cyborg boring-cyborg bot added github-actions Changes in GitHub workflows internal Maintenance changes labels Jan 13, 2025
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 13, 2025
Signed-off-by: Henrique Graca <999396+hjgraca@users.noreply.github.com>
@leandrodamascena leandrodamascena merged commit 2216fbf into develop Jan 13, 2025
5 checks passed
@leandrodamascena leandrodamascena deleted the hjgraca-patch-e2e branch January 13, 2025 15:13
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.32%. Comparing base (5110cc3) to head (cff2770).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #686      +/-   ##
===========================================
- Coverage    73.34%   73.32%   -0.03%     
===========================================
  Files          200      200              
  Lines         8112     8112              
  Branches       872      872              
===========================================
- Hits          5950     5948       -2     
- Misses        1874     1875       +1     
- Partials       288      289       +1     
Flag Coverage Δ
unittests 73.32% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hjgraca hjgraca mentioned this pull request Jan 13, 2025
7 tasks
@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github-actions Changes in GitHub workflows internal Maintenance changes pending-release Fix or implementation already in dev waiting to be released size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants