fix: idempotency timeout bug

[scottgerring]

Issue #, if available:
#1281

Description of changes:

Fixes a bug in idempotency where the processing of a idempotent record can become stalled after an earlier Lambda timeout.

Checklist

• Meet tenets criteria
• Update tests
• Update docs
• PR title follows conventional commit semantics

Breaking change checklist

RFC issue #:

• Migration process documented
• Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[scottgerring]

I've gone through all uses of the DataRecord constructor and DataRecord::getExpiryTimestamp to make sure there are no other unit mismatch surprises. I think this covers it!

[codecov-commenter]

Codecov Report

Patch coverage: 60.00% and project coverage change: +0.24 🎉

Comparison is base (c7aedc4) 78.94% compared to head (40390f4) 79.19%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1285      +/-   ##
============================================
+ Coverage     78.94%   79.19%   +0.24%     
- Complexity      629      639      +10     
============================================
  Files            72       73       +1     
  Lines          2332     2360      +28     
  Branches        253      258       +5     
============================================
+ Hits           1841     1869      +28     
+ Misses          412      410       -2     
- Partials         79       81       +2     

Impacted Files	Coverage Δ
...powertools/idempotency/persistence/DataRecord.java	73.17% <ø> (ø)
...lambda/powertools/parameters/DynamoDbProvider.java	80.32% <8.33%> (-3.01%)	⬇️
.../lambda/powertools/parameters/SecretsProvider.java	65.85% <10.00%> (-0.82%)	⬇️
...azon/lambda/powertools/parameters/SSMProvider.java	87.14% <70.00%> (+6.26%)	⬆️
...oftware/amazon/lambda/powertools/sqs/SqsUtils.java	79.72% <95.23%> (+4.72%)	⬆️
...mpotency/persistence/DynamoDBPersistenceStore.java	88.19% <100.00%> (+0.08%)	⬆️
...zon/lambda/powertools/parameters/ParamManager.java	77.77% <100.00%> (+0.85%)	⬆️
...ption/SkippedMessageDueToFailedBatchException.java	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[jeromevdl]

few things to look at

[jeromevdl]

good for me!

[scottgerring]

Retested using powertools-examples-idempotency as well as the fixed tests in here. This is good to go.