chore: Periodic merge of main into v2 #1525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: check if XRAY Trace ID is present in System property * chore: remove erroneous extra char in tests
* handle AWS_LAMBDA_LOG configuration * ALC documentation + code review * update doc
* chore:prep release 1.18.0 * update version * update version in kotlin example * maven local repo in gradle example * update changelog --------- Co-authored-by: scottgerring <scottgerring@users.noreply.github.com>
* update version to next snapshot: 1-19.0-SNAPSHOT * update version to next snapshot: 1-19.0-SNAPSHOT * update version to next snapshot: 1-19.0-SNAPSHOT * building only for LTS
* e2e tests with java 21 * Run Java21 tests using the Java17 compiler * Run all of the E2E tests in parallel, not just the first 3 * Try again * . * Let's try again * Add some comment on Java21 to the repo * Add caveat about lambda runtimes * Clean up wording a little --------- Co-authored-by: Scott Gerring <gerrings@amazon.com>
* e2e tests with java 21 * use aspectj 1.9.21-SNAPSHOT * Fix log4j2.xml missing in logging test for java21 * rollback double runtime * remove comment * keep aspectj 1.9.7 in parent for java8 compatibility * use M1 instead of snapshot * update documentation for aspectj * update documentation for aspectj --------- Co-authored-by: Jerome Van Der Linden <jeromevdl@gmail.com>
Contributor
💾 Artifacts Size Report
|
jeromevdl
reviewed
Nov 21, 2023
jeromevdl
reviewed
Nov 21, 2023
jeromevdl
suggested changes
Nov 21, 2023
Contributor
jeromevdl
left a comment
jeromevdl
left a comment
There was a problem hiding this comment.
not the latest version (README)
jeromevdl
reviewed
Nov 22, 2023
...rc/main/java/software/amazon/lambda/powertools/logging/internal/LambdaTimestampResolver.java
Show resolved
Hide resolved
jeromevdl
reviewed
Nov 22, 2023
.../java/software/amazon/lambda/powertools/logging/internal/LambdaTimestampResolverFactory.java
Show resolved
Hide resolved
jeromevdl
reviewed
Nov 22, 2023
jeromevdl
previously approved these changes
Nov 22, 2023
Contributor
jeromevdl
left a comment
jeromevdl
left a comment
There was a problem hiding this comment.
Apart from the logging (ALC), it's ok, should I do the appropriate merge in the logging branch?
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## v2 #1525 +/- ##
=====================================
Coverage ? 77.75%
Complexity ? 623
=====================================
Files ? 83
Lines ? 2504
Branches ? 270
=====================================
Hits ? 1947
Misses ? 469
Partials ? 88 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.