docs: Implement Logger and Tracer part #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msailes
reviewed
Aug 17, 2020
msailes
reviewed
Aug 17, 2020
| @PowerToolsLogging(logEvent = true) | ||
| public APIGatewayProxyResponseEvent handleRequest(final APIGatewayProxyRequestEvent input, final Context context) { | ||
| ... | ||
| PowerLogger.customKey("test", "willBeLogged"); |
Contributor
There was a problem hiding this comment.
We will probably rename this api based on suggestion from heitor to make it explicit that it will append to the log. Just a note
pankajagrawal16
approved these changes
Aug 19, 2020
Contributor
pankajagrawal16
left a comment
pankajagrawal16
left a comment
There was a problem hiding this comment.
Looks good to me
Contributor
|
Probably need to rebase with master :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Implement 2 new docs pages:
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.