Skip to content

Conversation

@kozub
Copy link
Contributor

@kozub kozub commented Jan 5, 2022

Issue #, if available:

#630

Description of changes:

Added new section for FAQs (intended as a page with usefull for users information that are not related to other sections)

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

docs/FAQs.md Outdated

To enable in-place weaving feature you need to use following `aspectj-maven-plugin` configuration:

```xml hl_lines="5"
Copy link
Contributor

@pankajagrawal16 pankajagrawal16 Jan 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is hl line number correct here? Seems to point to </weaveDirectories>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching it. You are rigth - it was a bit confusing. I've changed it to highlight all 5 lines which needs to be added to configuration. I also added <forceAjcCompile>true</forceAjcCompile> which was not required when I tested in on my environment, but aspectj docs says that by default it's false so the code will not be recompiled.

Please let me know of you want me to squash commits before merge.

@pankajagrawal16 pankajagrawal16 merged commit 0722e92 into aws-powertools:master Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants