fix: cold start only on on-demand invocation

[Attyuttam]

Summary

Changes

Fixes #2113 - cold start only for on-demand invocation type else its not considered

---

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

[dreamorosi]

Hi @Attyuttam thank you for the PR.

Before we can start with the review, please make sure that the project still compiles after having made changes. Currently the CI is failing across the board.

If you have questions, please let us know.

[phipag]

@Attyuttam The CI fails due to broken unit tests. You can run locally mvn clean test to verify tests before updating the PR.

My suggestion is to update the failing unit test by setting the environment variable you are checking for. You can use @SetEnvironmentVariable for this. Here is an example of a test doing something similar:

https://github.com/Attyuttam/powertools-lambda-java/blob/090de1d6d2d34f87820d242bc3a81a28d7945291/powertools-common/src/test/java/software/amazon/lambda/powertools/common/internal/LambdaHandlerProcessorTest.java#L150-L159

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Attyuttam]

Still working on this, there are a lot of test failures due to the code change, will update and drop a message here !
Apologies for the delay, new to the ecosystem.