-
Notifications
You must be signed in to change notification settings - Fork 462
refactor(event-handler): remove kwargs from AppSync exception constructor #7699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
|
**kwargs from UnauthorizedException class.**kwargs from UnauthorizedException class.
**kwargs from UnauthorizedException class.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7699 +/- ##
========================================
Coverage 96.52% 96.52%
========================================
Files 275 275
Lines 13117 13117
Branches 986 986
========================================
Hits 12661 12661
Misses 353 353
Partials 103 103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dreamorosi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @T90REAL, thank you for sending the PR.
Well done 🚢 !
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |



Issue number: closes #7693
Summary
Remove
**kwargsfrom the signature to avoid confusing customers.Changes
Delete
**kwargsfrom argument and doc.User experience
User will not be confused by the signatures.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.