fix(logger): infinite loop on log buffer when item size is max bytes #4741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
logger
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
Contributor
|
Thank you for the PR, we'll review it soon. |
fidelisojeah
commented
Nov 13, 2025
dreamorosi
reviewed
Nov 13, 2025
Contributor
dreamorosi
left a comment
dreamorosi
left a comment
There was a problem hiding this comment.
Set @svozza as reviewer
fidelisojeah
force-pushed
the
fojeah/fix-logger-buffer-infinite-loop
branch
from
facf526 to
83e904d
Compare
fidelisojeah
changed the title
svozza
reviewed
Nov 13, 2025
Contributor
|
Nice work @fidelisojeah! I only had two very minor comments. |
fidelisojeah
force-pushed
the
fojeah/fix-logger-buffer-infinite-loop
branch
from
83e904d to
2c5e55b
Compare
|
svozza
approved these changes
Nov 13, 2025
Contributor
|
Great stuff @fidelisojeah , merging now! |
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR fixes a bug where an infinite loop occurs when a new buffered log's byte size is equal to the maxBytes size (
logBufferOptions.maxBytes) specified while log buffering is enabled (logBufferOptions.enabled = true).See issue for more details.
Issue number: closes #4737
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.