This repository was archived by the owner on Oct 4, 2024. It is now read-only.
applying gitlab fixes #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaymccon
approved these changes
May 14, 2019
Contributor
|
Thanks for the contribution @josjaf 😃 |
Contributor
Author
|
No problem - let me know if you have any issues during testing - happy to help you work through them. At this point - I diverged from your code for my gitlab to S3, so it might take a bit of effort for me to stand this back up. |
pedrojmendoza
added a commit
to pedrojmendoza/quickstart-git2s3
that referenced
this pull request
Jul 1, 2019
As part of aws-quickstart#33, a Python 3 only string formatting mechanism was introduced (https://realpython.com/python-f-strings/) but the CFN template is still using python2.7 as runtime for the lambdas hence a SyntaxError is happening
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixing bad hooks to gitlab
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.