This repository was archived by the owner on Oct 4, 2024. It is now read-only.
Un-escape single quotes #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves an issue where invalid single quote escaping causes failure when a commit message contains a single quote. Single quotes should not be escaped in JSON.
jaymccon
approved these changes
Nov 17, 2017
Contributor
jaymccon
left a comment
jaymccon
left a comment
There was a problem hiding this comment.
looks good :)
merging to develop branch. Once ci is happy, the commit will get pushed to the master branch and templates in the quickstart-reference s3 bucket will be updated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an issue where invalid single quote escaping causes failure when a commit message contains a single quote. Single quotes should not be escaped in JSON.
When this error occurs, the response from the POST from github is:
{"message": "Could not parse request body into json: Unrecognized character escape ''' (code 39)...
The fix is described in the AWS reference for $util.escapeJavaScript() here:
http://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-mapping-template-reference.html