Feature/Dpra-91

[aniketkb2014]

1. Adding the codepipeline source to choose from external version control system ( GitHub),
   a. Using codeconnection to configure setup for github

2. Updating the iam policy required for tagging the resources

[davidhessler]

nit: this is not idiomatic Typescript. See example

class foo {
    private _bar: boolean = false;
    get bar(): boolean {
        return this._bar;
    }
    set bar(value: boolean) {
        this._bar = value;
    }
}```

[davidhessler]

type needs to be a enum

[davidhessler]

Why does this need to be it's own Construct Couldn't we extend CodePipelineSource or create a factory class instead?

[aniketkb2014]

We considered the external source to be a separate construct since it was experiencing different connectivity through codeconnections.

[davidhessler]

By that logic, this should be a class, but I'm not seeing the benefit of a Construct. Particularly because in many cases the CodeConnection is global and/or created outside the scope of a specific CDK Construct (e.g. Stack). It is worth noting that CodePipelineSource itself is a class but does not Construct. Said simply, not all classes need to be a Construct.

What I believe the intent of this code here is to be a factory class that creates pre-configured instances of CodePipelineSource based upon a simplified set of parameters (e.g. ExternalSourceProps).

If that's the case then this class should look more the following

export class CodePipelineSourceFactory{
  static createCodePipelineSource(pipelineStack: PipelineStack){
    const providerType = pipelineStack.node.tryGetContext("providerType")==undefined?"codecommit":pipelineStack.node.tryGetContext("providerType");

    switch(providerType){
      case 'codecommit':
        const appName = pipelineStack.node.tryGetContext('appName')
        if(!appName){
          throw new Error('appName is required')
        }
        // CodeCommitSource is an instance of Construct
        return new CodeCommitSource(pipelineStack, 'Source', {repositoryName: appName})
      default:
        const repoParameters = {
          "owner": pipelineStack.node.tryGetContext('owner'),
          "repositoryName": pipelineStack.node.tryGetContext('repositoryName'),
          "trunkBranchName": pipelineStack.node.tryGetContext('trunkBranchName'),
          "connectionArn": pipelineStack.node.tryGetContext('connectionArn'),
        };

        // CodePipelineSource is not an instance of Construct
        return CodePipelineSource.connection(
          `${repoParameters.owner}/${repoParameters.repositoryName}`,
          repoParameters.trunkBranchName ?? 'main',
          { connectionArn: repoParameters.connectionArn }
        )
    }
}