Docker Images #113
Merged
Docker Images #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RogerZhongAWS
added
bug
RogerZhongAWS
force-pushed
the
docker-builds
branch
from
8ee2812 to
d3c1407
Compare
RogerZhongAWS
force-pushed
the
docker-builds
branch
from
2b15906 to
3dcc81b
Compare
update docker build action remove cache deletion fix typo update stage1 file modify dockerfiles change download dir delete fedora arm build update macos ci openssl version readme update
RogerZhongAWS
force-pushed
the
docker-builds
branch
from
0ce0b64 to
d0329d2
Compare
shangabl
suggested changes
Feb 28, 2023
shangabl
approved these changes
Mar 3, 2023
Contributor
shangabl
left a comment
shangabl
left a comment
There was a problem hiding this comment.
Approving but please don't merge until we have the repos setup.
| mkdir build | ||
| cd build | ||
| cmake .. -DBUILD_TESTS=OFF -DOPENSSL_ROOT_DIR=/usr/local/Cellar/openssl@1.1/1.1.1s/ -DOPENSSL_LIBRARIES=/usr/local/Cellar/openssl@1.1/1.1.1s/lib/ | ||
| cmake .. -DBUILD_TESTS=OFF -DOPENSSL_ROOT_DIR=/usr/local/Cellar/openssl@1.1/1.1.1t/ -DOPENSSL_LIBRARIES=/usr/local/Cellar/openssl@1.1/1.1.1t/lib/ |
Contributor
There was a problem hiding this comment.
we will have to make changes in the code every time a new version of openSSL is released. Can we update the code to use the latest a specific version of OpenSSL instead?
Contributor
There was a problem hiding this comment.
If I install openssl@1.1 using brew on my mac, it is downloading and installing 1.1.1q version instead of 1.1.1t.
$ brew install openssl@1.1
Warning: openssl@1.1 1.1.1q is already installed and up-to-date.
To reinstall 1.1.1q, run:
brew reinstall openssl@1.1
ls /usr/local/Cellar/openssl@1.1/
1.1.1g 1.1.1q
Contributor
There was a problem hiding this comment.
Discussed with team and decided to have a followup change for mac os.
HarshGandhi-AWS
approved these changes
Mar 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Change summary
Testing
Is your change tested? If not, please justify the reason.
Please list your testing steps and test results.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.