feat: streaming support for qnabot II #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

atjohns merged 1 commit into development from feat/streamingqna

Nov 12, 2024

Contributor

abhirpat commented Nov 11, 2024 •

edited

Loading

Description of changes:

Previous: PR #758
This optimizes to allow passing BYO StreamingWebSocketEndpoint without needing while AllowStreamingResponses true. Because of this, it prevents creation of unnecessary streaming resources. It also merges variables so they are not cached loader config
- Successfully tested below scenarios :
  - New Stack Deployment and Update Stack
  - Case 1: AllowStreamingResponses to False and StreamingWebSocketEndpoint is empty
  - Case 2a: AllowStreamingResponses to True and StreamingWebSocketEndpoint is empty
  - Case 2b: change AllowStreamingResponses to False and StreamingWebSocketEndpoint is empty
  - Case 3: AllowStreamingResponses to False and StreamingWebSocketEndpoint is defined

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

abhirpat requested a review from atjohns

November 11, 2024 23:38


          feat: streaming support for qnabot II

08be466

abhirpat force-pushed the feat/streamingqna branch from 6ea2c7c to 08be466 Compare

November 12, 2024 15:28

abhirpat self-assigned this

atjohns merged commit 1d8fcf0 into development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet