Updated Java dependencies and Code #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure. |
github-actions
bot
added
do-not-merge
sliedig
approved these changes
Aug 27, 2025
Contributor
sliedig
left a comment
sliedig
left a comment
There was a problem hiding this comment.
Great work, thank you @eldritchideen !!
|
undefined No related issues found. Please ensure 'pending-release' label is applied before releasing. |
sliedig
added a commit
that referenced
this pull request
Aug 27, 2025
* feat: add command to list the parameters in parameters store * refactor: renamed UnicornPropertiesNamespace to UnicornApprovalsNamespace in shared namespace definition * refactor: updated resolve:ssm references for UnicornPropertiesNamespace to UnicornApprovalsNamespace across multiple templates * refactor: change event bus references from UnicornPropertiesEventBus to UnicornApprovalsEventBus across multiple files * chore: upgrade actions/upload-artifact from v3 to v4 in GitHub workflow * feat: refactored unicorn properties to approvals again. Renamed modules to align with oother runtimes. * refactor: updated POM file to rename groupId and artifactId from PropertyService to ApprovalsService for consistency with recent changes * chore: update .gitignore to include new target directories for ApprovalService, ContractsService, SearchService, and Common * refactor: simplify setUp method in CreateContractTests by removing unnecessary exception declaration * refactor: simplify setUp method in ContractStatusTests by removing unnecessary exception declaration * refactor: update POM files to rename artifactId and module names for consistency, and upgrade compiler version to 17 * chore: update .gitignore to reflect the new directory structure for ApprovalsService * feat: refactored unicorn web into separate modules - ApprovalService and SearchService - to align with implementations in other runtimes. * chore: update Approvals readme * chore: updated contracts readme * chore: update web readme * chore: updated main readme * chore: update GitHub Actions workflows to use latest versions of actions and increase build timeout * chore: downgrade Maven compiler version to 17 in Common module * chore: reorder sections in README and update image placement * chore: update README badge link to reflect new GitHub Actions workflow * chore: fix formatting in README by adjusting header and image placement * refactor: change package name from search.requestapproval to approval.requestapproval in RequestApprovalFunction.java * chore: update architecture diagram * refactor: update event source and rule names to use 'unicorn.approvals' * refactor: change package names from 'unicorn_properties' to 'unicorn_approvals' in related classes * refactor: rename ApprovalService to PublicationManagerService and removed classes in the ApprovalsService module as this does not need to be tracked. * chore: minor update to readme file * fix: update namespace for event schema * fix: updated references to properties service to approvals service. Fixed SAM templates to refer to new Java services. Updated .gitignore. Updated test events. * chore: updated approvals readme * chore: updated readme and spelling mistakes * fix: syncing templates * Updated Java dependencies and Code (#47) * Updated unicorn approvals dependencies and updated code. * Updated Unicorn Contracts. * Updated unicorn web. --------- Co-authored-by: SDE Workshop User <ec2-user@sde-workshop.local> Co-authored-by: Steven Cook <awscook@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Summary
Updated Java libraries to their latest versions. Updated the code to reflect more modern Java practices. Code builds and unit tests are passing.
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.