fix: deprecated code, RDS's instanceProps and CloudWatch Synthetics's older runtime #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konokenj
force-pushed
the
fix-deprecated-rds-and-cwsynthetics
branch
from
31dd219 to
735db26
Compare
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This was referenced Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#604 , #652 show the issues of deprecated properties.
This PR is to fix them.
In #604,
instancePropswas deprecated.So, it uses
writerandreadersprops instead of it.In #652,
synthetics.Runtime.SYNTHETICS_NODEJS_PUPPETEER_3_5was deprecated.So, it updates
puppeteerversion from3.5to6.0.Because BLEA`s comment recommends to use the latest version.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT No Attribution (MIT-0).