Skip to content

fix: deprecated code, RDS's instanceProps and CloudWatch Synthetics's older runtime #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 21, 2024
Merged

fix: deprecated code, RDS's instanceProps and CloudWatch Synthetics's older runtime #662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6ac0579
fix: use writer/readers props instead of instanceProps that was depre…
suzukyz Feb 9, 2024
f1100d6
fix: upgrade canary runtime verion. 3.5 was deprecated.
suzukyz Feb 9, 2024
087081b
test: update snapshot test
suzukyz Feb 9, 2024
ebcd2bf
fix: test code
suzukyz Feb 13, 2024
7465b23
fix: test code
suzukyz Feb 13, 2024
4e5715d
fix: test code
suzukyz Feb 13, 2024
ddc925b
fix: keep exisiting db instances
suzukyz Feb 20, 2024
735db26
fix: test code
suzukyz Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion usecases/blea-guest-ecs-app-sample/lib/construct/canary.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export class Canary extends Construct {
}),
// It's recommended that use the latest runtime version.
// See: https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Canaries_Library.html
runtime: synthetics.Runtime.SYNTHETICS_NODEJS_PUPPETEER_3_5,
runtime: synthetics.Runtime.SYNTHETICS_NODEJS_PUPPETEER_6_0,
environmentVariables: {
TARGETHOST: props.appEndpoint,
TARGETPATH: '/',
Expand Down
24 changes: 18 additions & 6 deletions usecases/blea-guest-ecs-app-sample/lib/construct/datastore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,28 @@ export class Datastore extends Construct {
// version: rds.AuroraMysqlEngineVersion.VER_2_09_1
// }),
credentials: rds.Credentials.fromGeneratedSecret('dbadmin'),
instanceProps: {
vpcSubnets: {
subnetType: SubnetType.PRIVATE_ISOLATED,
},
vpc: props.vpc,
writer: rds.ClusterInstance.provisioned('Instance1', {
instanceIdentifier: 'Datastore1',
instanceType: InstanceType.of(InstanceClass.T3, InstanceSize.MEDIUM),
vpcSubnets: {
subnetType: SubnetType.PRIVATE_ISOLATED,
},
vpc: props.vpc,
enablePerformanceInsights: true,
performanceInsightEncryptionKey: props.cmk,
performanceInsightRetention: rds.PerformanceInsightRetention.DEFAULT, // 7 days
},
isFromLegacyInstanceProps: true,
}),
readers: [
rds.ClusterInstance.provisioned('Instance2', {
instanceIdentifier: 'Datastore2',
instanceType: InstanceType.of(InstanceClass.T3, InstanceSize.MEDIUM),
enablePerformanceInsights: true,
performanceInsightEncryptionKey: props.cmk,
performanceInsightRetention: rds.PerformanceInsightRetention.DEFAULT, // 7 days
isFromLegacyInstanceProps: true,
}),
],
removalPolicy: RemovalPolicy.SNAPSHOT,
defaultDatabaseName: 'mydb',
storageEncrypted: true,
Expand Down
2 changes: 1 addition & 1 deletion usecases/blea-guest-ecs-app-sample/test/__snapshots__/blea-guest-ecs-app-sample.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4059,7 +4059,7 @@ exports[`Snapshot test for BLEA ECS App Stacks 3`] = `
"TARGETPATH": "/",
},
},
"RuntimeVersion": "syn-nodejs-puppeteer-3.5",
"RuntimeVersion": "syn-nodejs-puppeteer-6.0",
"Schedule": {
"DurationInSeconds": "0",
"Expression": "rate(1 minute)",
Expand Down