feat: Updated based on ECS workshop experience #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Great effort on this architecture diagram. Given this is our main Diagram that explains ECS SaaS its great other improve that in a way it make sense.
- Good to have CoreAppPlane to go with SBT naming convention. Pls consider renaming :
SaaS Control plane (SBT)
SaaS Application plan
- Core Application Plane (SBT)
- ECS Application plane
--- Basic
--- Advanced
--- Premium
- Remove Margate images from Advanced and Premium, and a caption "Amazon ECS" would be better next to to the icon
- Remove S3 bucket and Rout53 icons, as they might not add value as in this level diagram
- Remove "Tenant" that is in between Cognito and Admin console as it is misleading both tenants and SaaS provider connects to the same Admin console. And, rename Admin console into SaaS Admin console. If we want to showcase Tenant admin panel, we can consider add it next to the "Tenant" that is connecting to the SaaS app .
Contributor
Author
There was a problem hiding this comment.
Yes, I'll make it more simple at next PR as we discussted.
Contributor
dhammikasriya-aws
left a comment
dhammikasriya-aws
left a comment
There was a problem hiding this comment.
Pls review, one comment about the archi. diagram.
dhammikasriya-aws
approved these changes
Sep 16, 2024
Contributor
dhammikasriya-aws
left a comment
dhammikasriya-aws
left a comment
There was a problem hiding this comment.
Main architecture diagram changes will be handled separately. Rest is Good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.