Add compute type argument #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaipreet-s
suggested changes
Mar 16, 2021
sagemaker_studio_image_build/cli.py
Outdated
Comment on lines
81
to
84
| build_parser.add_argument( | ||
| "--image", | ||
| help="The ECR repository:tag for the image (default: sagemaker-studio-${domain_id}:latest)", | ||
| ) |
Contributor
There was a problem hiding this comment.
This looks identical to the --repository parameter. What is the use for this?
Suggested change
| build_parser.add_argument( | |
| "--image", | |
| help="The ECR repository:tag for the image (default: sagemaker-studio-${domain_id}:latest)", | |
| ) |
Contributor
Author
There was a problem hiding this comment.
I was also going to add support for targeting a different CodeBuild image in addition to compute type. But decided to keep this PR just to compute type - so I will remove this option.
sagemaker_studio_image_build/cli.py
Outdated
| ) | ||
| build_parser.add_argument( | ||
| "--compute-type", | ||
| help="The code build compute type (default: BUILD_GENERAL1_SMALL)", |
Contributor
There was a problem hiding this comment.
nitpick: s/code build/CodeBuild
Suggested change
| help="The code build compute type (default: BUILD_GENERAL1_SMALL)", | |
| help="The CodeBuild compute type (default: BUILD_GENERAL1_SMALL)", |
sagemaker_studio_image_build/cli.py
Outdated
Comment on lines
30
to
35
| if not args.compute_type in ['BUILD_GENERAL1_SMALL', 'BUILD_GENERAL1_MEDIUM', | ||
| 'BUILD_GENERAL1_LARGE', 'BUILD_GENERAL1_LARGE', 'BUILD_GENERAL1_LARGE', 'BUILD_GENERAL1_2XLARGE']: | ||
| raise ValueError( | ||
| f'Error parsing reference: "{args.repository}" is not a valid repository/tag' | ||
| ) | ||
|
|
Contributor
There was a problem hiding this comment.
This can be simplified by using the choices functionality in argparse. For e.g.,
parser.add_argument('compute-type', choices=['BUILD_GENERAL1_LARGE', 'BUILD_GENERAL1_2XLARGE', '...'], default='BUILD_GENERAL1_SMALL')
Contributor
Author
There was a problem hiding this comment.
Fixed in update.
jaipreet-s
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #5
Description of changes:
Add
--compute-typeargument to allow specifying the compute type down to the AWS CodeBuild job.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.