New Serverless Pattern - Route53-ALB-S3 (hosting a private website) #2438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfreiberg
requested changes
Sep 5, 2024
route53-alb-s3/README.md
Outdated
|
|
||
| 2. From the CloudShell command prompt run the following command to access your private website. Replace `{PrivateWebsiteUrl}` with the corresponding output value of the `sam deploy` command: | ||
| ``` | ||
| curl -v -k -L {PrivateWebsiteUrl} |
Contributor
There was a problem hiding this comment.
please give a one sentence explanation what these parameters do. Also, is -v necessary?
Contributor
There was a problem hiding this comment.
@bfreiberg I have added some explanation to the command. Yeah -v is probably not needed and have removed it. I was using it primarily to test if the cert chain was indeed a private one or not.
route53-alb-s3/template.yaml
Outdated
Comment on lines
385
to
386
|
|
||
|
|
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
…b-s3' into biswanathmukherjee-feature-r53-alb-s3
bfreiberg
approved these changes
Sep 10, 2024
Contributor
|
Looks good, thanks for your contribution. Your pattern will be merged soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This pattern deploys a framework to host a internal static website on Amazon S3 bucket that can only be accessed from private network.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.