New serverless pattern: appsync-events-bedrock-cdk #2508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbiagini97
changed the title
marcojahn
requested changes
Dec 13, 2024
Contributor
There was a problem hiding this comment.
I am not able to deploy, running step 4 from deployement instructions (npm run deploy) results in an error:
11:01:18 AM | CREATE_FAILED | AWS::AppSync::ApiKey | ApiKey
API key must be valid for a minimum of 1 days. (Service: AWSAppSync; Status Code: 400; Error Code: ApiKeyValidityOutOfBou
ndsException; Request ID: 4c4651cb-809a-4c09-a27c-39f3645fa860; Proxy: null)
The current pattern is broken after 12.12.
ApiKey:
Type: AWS::AppSync::ApiKey
Properties:
ApiId: !GetAtt EventsApi.ApiId
Description: Api Key for Events Api
Expires: 1733989774
As the API_KEY can be only configured for up to 365 days [1] please add creation/update process do the deployment documentation, as otherwise the code will break (requiring users to debug) after 365 days.
[1] https://docs.aws.amazon.com/appsync/latest/devguide/security-authz.html#api-key-authorization
Co-authored-by: Marco <marco.jahn@gmail.com>
Co-authored-by: Marco <marco.jahn@gmail.com>
Co-authored-by: Marco <marco.jahn@gmail.com>
Co-authored-by: Marco <marco.jahn@gmail.com>
Co-authored-by: Marco <marco.jahn@gmail.com>
Co-authored-by: Marco <marco.jahn@gmail.com>
Co-authored-by: Marco <marco.jahn@gmail.com>
Co-authored-by: Marco <marco.jahn@gmail.com>
Co-authored-by: Marco <marco.jahn@gmail.com>
Co-authored-by: Marco <marco.jahn@gmail.com>
Co-authored-by: Marco <marco.jahn@gmail.com>
Contributor
Author
|
@marcojahn sorry for the late. I addressed your points and removed the components defined via plain CFN. Now it's CDK-only. |
marcojahn
approved these changes
Mar 18, 2025
Contributor
marcojahn
left a comment
marcojahn
left a comment
There was a problem hiding this comment.
Hello @gbiagini97,
thanks for your contribution. A serverless DA will merge your PR soon!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#2509
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.