New serverless pattern - apigw-websocket-mapping-template-authorizer #2609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliceincloudland
changed the title
marcojahn
requested changes
Feb 18, 2025
Contributor
marcojahn
left a comment
marcojahn
left a comment
There was a problem hiding this comment.
Hi @aliceinaws,
thank you for your contribution, I've added a few comments and requests for changes. Pls review and apply. TY
apigw-websocket-mapping-template-authorizer/src/sendmessage.mjs
Outdated
Show resolved
Hide resolved
apigw-websocket-mapping-template-authorizer/src/sendmessage.mjs
Outdated
Show resolved
Hide resolved
apigw-websocket-mapping-template-authorizer/src/sendmessage.mjs
Outdated
Show resolved
Hide resolved
Contributor
|
Hi @aliceinaws, this issue is becoming stale. Do you still plan to work on it? |
Author
|
Hi @marcojahn sorry about the delay and thanks for your inputs. All the necessary changes should be made now, let me know if there's anything else ! |
marcojahn
requested changes
May 9, 2025
Contributor
marcojahn
left a comment
marcojahn
left a comment
There was a problem hiding this comment.
Hello @aliceinaws, thank you for the updates. One small remaining issue, then all good.
marcojahn
requested changes
May 9, 2025
Contributor
marcojahn
left a comment
marcojahn
left a comment
There was a problem hiding this comment.
Hello @aliceinaws, 4 remaining wording updates.
apigw-websocket-mapping-template-authorizer/example-pattern.json
Outdated
Show resolved
Hide resolved
apigw-websocket-mapping-template-authorizer/example-pattern.json
Outdated
Show resolved
Hide resolved
apigw-websocket-mapping-template-authorizer/example-pattern.json
Outdated
Show resolved
Hide resolved
apigw-websocket-mapping-template-authorizer/example-pattern.json
Outdated
Show resolved
Hide resolved
marcojahn
approved these changes
May 19, 2025
Contributor
marcojahn
left a comment
marcojahn
left a comment
There was a problem hiding this comment.
TY @aliceinaws for your contribution. Your PR will be merged to serverlessland soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2610, if available:
Description of changes:
This projects demonstrates how to use a WebSocket API with a Lambda Authorizer. The WebSocket API does not have a Proxy integration with the back-end Lambda written NodeJs 22, instead it is using a mapping template that forwards the main information of the request.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.