New serverless pattern - Text translation with Lambda and Translate (Terraform) #2670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfreiberg
requested changes
Feb 26, 2025
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
MakendranG
commented
Feb 27, 2025
Contributor
Author
MakendranG
left a comment
MakendranG
left a comment
There was a problem hiding this comment.
Have added the suggested changes
bfreiberg
requested changes
Feb 28, 2025
Contributor
bfreiberg
left a comment
bfreiberg
left a comment
There was a problem hiding this comment.
Looks good, some minor comments still left
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
MakendranG
commented
Mar 1, 2025
Contributor
Author
MakendranG
left a comment
MakendranG
left a comment
There was a problem hiding this comment.
Have updated the necessary change
Contributor
|
Looks good, thanks for your contribution. Please address that last comment and then it's good to go |
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
Contributor
|
Looks good, thanks for your contribution. Your PR will be merged to Serverlessland soon |
bfreiberg
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This pattern shows how to deploy a terraform template that builds a Lambda function which calls translate for text translation.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.