Fix for issue #53: last_frame_line_no is None #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason.
To try to fix - FAILED test/unit/test_sampler.py::TestWhenThereAreMoreThreadsThanMaxThreads::test_it_calls_the_get_stacks_method_with_a_subset_of_the_threads - TypeError: Population must be a sequence. For dicts or sets, use sorted(d).
revert test to original
Solve typeerror
yansam-amazon
approved these changes
Feb 15, 2024
yansam-amazon
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: 53
Description of changes: In the case last_frame_line_no on the stack is None, ignore the line. Additionally adjust integration tests to get them to pass. Add testing for python 3.10 and 3.11
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.