Skip to content

Conversation

@affonsov
Copy link
Contributor

Summary

[AD-883] Check/Update documentation

Description

Documentation and notice file were updated.

Related Issue

https://bitquill.atlassian.net/browse/AD-883

Additional Reviewers

@affonsoBQ
@alexey-temnikov
@alinaliBQ
@andiem-bq
@birschick-bq
@mitchell-elholm
@RoyZhang2022

@github-actions
Copy link

github-actions bot commented Aug 23, 2022

MacOS Big Sur 11 Debug Build Unit Test Results

    1 files  ±0      1 suites  ±0   36s ⏱️ -15s
268 tests ±0  256 ✔️ ±0  12 💤 ±0  0 ±0 
256 runs  ±0  244 ✔️ ±0  12 💤 ±0  0 ±0 

Results for commit 5863ebc. ± Comparison against base commit 5690962.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 23, 2022

Windows 2022 (x32) Build Unit Test Results

    1 files  ±0      1 suites  ±0   1m 7s ⏱️ -7s
271 tests ±0  259 ✔️ ±0  12 💤 ±0  0 ±0 
259 runs  ±0  247 ✔️ ±0  12 💤 ±0  0 ±0 

Results for commit 5863ebc. ± Comparison against base commit 5690962.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 23, 2022

Ubuntu 20.04 Debug Build Unit Test Results

    1 files  ±0      1 suites  ±0   30s ⏱️ +3s
271 tests ±0  259 ✔️ ±0  12 💤 ±0  0 ±0 
259 runs  ±0  259 ✔️ ±0    0 💤 ±0  0 ±0 

Results for commit 5863ebc. ± Comparison against base commit 5690962.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 23, 2022

Windows 2022 (x64) Build Unit Test Results

    1 files  ±0      1 suites  ±0   1m 11s ⏱️ -3s
271 tests ±0  259 ✔️ ±0  12 💤 ±0  0 ±0 
259 runs  ±0  247 ✔️ ±0  12 💤 ±0  0 ±0 

Results for commit 5863ebc. ± Comparison against base commit 5690962.

♻️ This comment has been updated with latest results.

added Power BI issue section
Copy link
Contributor

@alinaliBQ alinaliBQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm so far, waiting on changes to fill in the attribute table

Copy link
Contributor

@alinaliBQ alinaliBQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a nit comment and a question

Bruce Irschick and others added 3 commits August 25, 2022 16:50
Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com>
alinaliBQ
alinaliBQ previously approved these changes Aug 30, 2022
Copy link
Contributor

@alinaliBQ alinaliBQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Approved

@alinaliBQ alinaliBQ dismissed their stale review August 30, 2022 20:35

sorry, doing some more checks

Copy link
Contributor

@alinaliBQ alinaliBQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some comments that are requesting changes. Please correct me if I'm wrong.

Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com>
Copy link
Contributor

@alinaliBQ alinaliBQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Contributor

@andiemontoyeah andiemontoyeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits, LGTM

Co-authored-by: andiem-bq <67925459+andiem-bq@users.noreply.github.com>
@github-actions
Copy link

MacOS Big Sur 11 Debug Build Code Coverage Result

Code Coverage

Package Line Rate Branch Rate Complexity Health
src.odbc.include.documentdb.odbc 29% 37% 0
src.odbc.include.documentdb.odbc.app 20% 0% 0
src.odbc.include.documentdb.odbc.binary 0% 0% 0
src.odbc.include.documentdb.odbc.cache.query 0% 0% 0
src.odbc.include.documentdb.odbc.cluster 0% 0% 0
src.odbc.include.documentdb.odbc.common 13% 11% 0
src.odbc.include.documentdb.odbc.compute 0% 0% 0
src.odbc.include.documentdb.odbc.config 86% 50% 0
src.odbc.include.documentdb.odbc.diagnostic 86% 50% 0
src.odbc.include.documentdb.odbc.impl 0% 0% 0
src.odbc.include.documentdb.odbc.impl.binary 0% 0% 0
src.odbc.include.documentdb.odbc.impl.cache 0% 0% 0
src.odbc.include.documentdb.odbc.impl.cache.query 0% 0% 0
src.odbc.include.documentdb.odbc.impl.cache.query.continuous 0% 0% 0
src.odbc.include.documentdb.odbc.impl.compute 0% 0% 0
src.odbc.include.documentdb.odbc.impl.interop 0% 0% 0
src.odbc.include.documentdb.odbc.jni 48% 40% 0
src.odbc.include.documentdb.odbc.meta 47% 50% 0
src.odbc.include.documentdb.odbc.query 15% 0% 0
src.odbc.include.documentdb.odbc.sql 11% 0% 0
src.odbc.include.documentdb.odbc.streaming 0% 0% 0
src.odbc.os.linux.include.documentdb.odbc.common 0% 0% 0
src.odbc.os.linux.src.common 34% 35% 0
src.odbc.src 48% 27% 0
src.odbc.src.app 16% 3% 0
src.odbc.src.binary 0% 0% 0
src.odbc.src.cluster 2% 0% 0
src.odbc.src.common 22% 10% 0
src.odbc.src.config 70% 44% 0
src.odbc.src.diagnostic 44% 20% 0
src.odbc.src.impl 1% 0% 0
src.odbc.src.impl.binary 0% 0% 0
src.odbc.src.impl.cache 2% 0% 0
src.odbc.src.impl.cache.query 1% 0% 0
src.odbc.src.impl.cache.query.continuous 0% 0% 0
src.odbc.src.impl.cluster 2% 0% 0
src.odbc.src.impl.compute 0% 0% 0
src.odbc.src.impl.interop 1% 0% 0
src.odbc.src.jni 66% 26% 0
src.odbc.src.jni.os.linux 46% 23% 0
src.odbc.src.meta 89% 54% 0
src.odbc.src.query 63% 27% 0
src.odbc.src.sql 25% 9% 0
src.odbc.src.streaming 3% 0% 0
Summary 37% (5942 / 16210) 23% (9418 / 41564) 0

@github-actions
Copy link

Ubuntu 20.04 Debug Build Unit Test Results Check

Code Coverage

Package Line Rate Branch Rate Complexity Health
src.odbc.include.documentdb.odbc 41% 39% 0
src.odbc.include.documentdb.odbc.app 45% 0% 0
src.odbc.include.documentdb.odbc.binary 0% 0% 0
src.odbc.include.documentdb.odbc.cache.query 0% 0% 0
src.odbc.include.documentdb.odbc.common 61% 34% 0
src.odbc.include.documentdb.odbc.compute 0% 0% 0
src.odbc.include.documentdb.odbc.config 100% 50% 0
src.odbc.include.documentdb.odbc.diagnostic 82% 50% 0
src.odbc.include.documentdb.odbc.impl 0% 0% 0
src.odbc.include.documentdb.odbc.impl.binary 0% 0% 0
src.odbc.include.documentdb.odbc.impl.cache.query 0% 0% 0
src.odbc.include.documentdb.odbc.impl.cache.query.continuous 0% 0% 0
src.odbc.include.documentdb.odbc.impl.compute 0% 0% 0
src.odbc.include.documentdb.odbc.impl.interop 0% 0% 0
src.odbc.include.documentdb.odbc.jni 77% 39% 0
src.odbc.include.documentdb.odbc.meta 71% 50% 0
src.odbc.include.documentdb.odbc.query 20% 0% 0
src.odbc.include.documentdb.odbc.sql 50% 11% 0
src.odbc.include.documentdb.odbc.streaming 0% 0% 0
src.odbc.os.linux.include.documentdb.odbc.common 0% 0% 0
src.odbc.os.linux.src.common 34% 42% 0
src.odbc.src 46% 28% 0
src.odbc.src.app 25% 13% 0
src.odbc.src.binary 0% 0% 0
src.odbc.src.cluster 0% 0% 0
src.odbc.src.common 28% 17% 0
src.odbc.src.config 70% 45% 0
src.odbc.src.diagnostic 32% 15% 0
src.odbc.src.impl 0% 0% 0
src.odbc.src.impl.binary 0% 0% 0
src.odbc.src.impl.cache 0% 0% 0
src.odbc.src.impl.cache.query 0% 0% 0
src.odbc.src.impl.cache.query.continuous 0% 0% 0
src.odbc.src.impl.cluster 0% 0% 0
src.odbc.src.impl.compute 0% 0% 0
src.odbc.src.impl.interop 0% 0% 0
src.odbc.src.jni 63% 27% 0
src.odbc.src.jni.os.linux 38% 20% 0
src.odbc.src.meta 88% 54% 0
src.odbc.src.query 59% 27% 0
src.odbc.src.sql 18% 8% 0
src.odbc.src.streaming 0% 0% 0
Summary 37% (5867 / 15795) 25% (9039 / 36759) 0

@github-actions
Copy link

Windows 2022 (x32) Debug Build Unit Test Results Check

Code Coverage

Package Line Rate Branch Rate Complexity Health
D:\a\amazon-documentdb-odbc-driver\amazon-documentdb-odbc-driver\build\odbc\bin\Debug\documentdb.odbc.dll 33% 0% 0
Summary 33% (6886 / 20891) 0% (0 / 0) 0

@affonsov affonsov merged commit 2737b11 into develop Sep 1, 2022
affonsov added a commit that referenced this pull request Nov 16, 2022
* updated notice file and documentation

Co-authored-by: Bruce Irschick <brucei@bitquilltech.com>
Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com>
Co-authored-by: andiem-bq <67925459+andiem-bq@users.noreply.github.com>
affonsov added a commit that referenced this pull request Nov 17, 2022
* updated notice file and documentation

Co-authored-by: Bruce Irschick <brucei@bitquilltech.com>
Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com>
Co-authored-by: andiem-bq <67925459+andiem-bq@users.noreply.github.com>
@affonsov affonsov deleted the affonsov/ad-883/update-documentation branch November 17, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants