- 
                Notifications
    
You must be signed in to change notification settings  - Fork 4
 
[AD-883] Check/Update documentation #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
added Power BI issue section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm so far, waiting on changes to fill in the attribute table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a nit comment and a question
Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some comments that are requesting changes. Please correct me if I'm wrong.
Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nits, LGTM
Co-authored-by: andiem-bq <67925459+andiem-bq@users.noreply.github.com>
          MacOS Big Sur 11 Debug Build Code Coverage Result
  | 
    
          Ubuntu 20.04 Debug Build Unit Test Results Check
  | 
    
* updated notice file and documentation Co-authored-by: Bruce Irschick <brucei@bitquilltech.com> Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com> Co-authored-by: andiem-bq <67925459+andiem-bq@users.noreply.github.com>
* updated notice file and documentation Co-authored-by: Bruce Irschick <brucei@bitquilltech.com> Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com> Co-authored-by: andiem-bq <67925459+andiem-bq@users.noreply.github.com>
Summary
[AD-883] Check/Update documentation
Description
Documentation and notice file were updated.
Related Issue
https://bitquill.atlassian.net/browse/AD-883
Additional Reviewers
@affonsoBQ
@alexey-temnikov
@alinaliBQ
@andiem-bq
@birschick-bq
@mitchell-elholm
@RoyZhang2022