generated from amazon-archives/__template_Apache-2.0
    
        
        - 
                Notifications
    
You must be signed in to change notification settings  - Fork 4
 
[AD-506] Reuse Apache Ignite JVM/JNI wrappers (examples) #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    * Refactor/copy from common to odbc project.
              
                    affonsov
  
              
              reviewed
              
                  
                    Jan 15, 2022 
                  
              
              
            
            
…H tunnel - for now.
              
                    birschick-bq
  
              
              commented
              
                  
                    Jan 19, 2022 
                  
              
              
            
            
              
                    affonsov
  
              
              reviewed
              
                  
                    Jan 21, 2022 
                  
              
              
            
            
              
                    alexey-temnikov
  
              
              approved these changes
              
                  
                    Jan 21, 2022 
                  
              
              
            
            
              
                    andiemontoyeah
  
              
              approved these changes
              
                  
                    Jan 21, 2022 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for detailed walkthrough! Another negative test case for connection would be a nice to have
    
  affonsov 
      pushed a commit
      that referenced
      this pull request
    
      Nov 16, 2022 
    
    
      
  
    
      
    
  
* simple query * Region is the key * log query result from Timestream * add Timestream types * remove credentials * roundtrip of query * working roundtrip simple query * cleanup * fix GitHub Action * move non-TS specific function to base class * revert the stack local variable ESResult es_result * add Timestream types Co-authored-by: Jerry Leung <jerryl@bitquilltech.com>
    
  affonsov 
      added a commit
      that referenced
      this pull request
    
      Nov 16, 2022 
    
    
      
  
    
      
    
  
* remove datum and timeseries datatype parser Co-authored-by: Bruce Irschick <brucei@bitquilltech.com>
    
  affonsov 
      pushed a commit
      that referenced
      this pull request
    
      Nov 16, 2022 
    
    
      
  
    
      
    
  
### Summary [AD-506] Reuse Apache Ignite JVM/JNI wrappers (examples) ### Description * Refactor existing Ignite JNI code into the ODBC project * Implement calls to use JNI to get a valid DocumentDB connection via JNI. * Get particular version of DocumentDB JDBC driver as part of build * Extend tests to include simple connection tests. TODO: * Setup secrets to allow connection to DocumentDB server via SSH tunnel * Enable MacOS build. ### Related Issue https://bitquill.atlassian.net/browse/AD-506 * [AD-506] Reuse Apache Ignite JVM/JNI wrappers (examples) * Refactor/copy from common to odbc project. * [AD-506] * Further refactor into odbc project. * [AD-506] * Add work to connect via JNI to DocumentDB JDBC driver. * [AD-506] * Correct build variables. * [AD-506] * Attempt correction for MacOS build * [AD-506] * Add registration of driver to workfow for windows. * [AD-506] * Correct declaration in connection.h. * [AD-506] * Correct initialization syntax error in MacOS build for java.cpp. * [AD-506] * Correct Linux/MacOS code for refactoring. * [AD-506] * Corrected driver registration. * [AD-506] * Add steps to run SSH tunnel. * [AD-506] * Remove flag to always run SSH tunnel. * [AD-506] * Fix registry and ssh tunnel. * [AD-506] * Fix ssh tunnel. * [AD-506] * Fix ssh tunnel. * [AD-506] * Fix ssh tunnel. * [AD-506] * Fix ssh tunnel. * [AD-506] * Fix ssh tunnel. * [AD-506] * Corrected driver registration. * [AD-506] * Change flags for SSH tunnel. * [AD-506] * Default known_hosts file. * [AD-506] * Default ssh config file. * [AD-506] * Disable external SSH tunnel - hard-code use of internal SSH tunnel - for now. * [AD-506] * Try register driver in windows 32-bit. * [AD-506] * Download JDBC driver for mac build. * [AD-506] * Download JDBC driver for mac build. * [AD-506] * Download JDBC driver for mac build. * [AD-506] * Download JDBC driver for mac build. * [AD-506] * Download JDBC driver for mac build. * [AD-506] * Download JDBC driver for mac build. * [AD-506] * Set the correct DOCUMENTDB_HOME. * [AD-506] * Make the build script exit on any error. * [AD-506] * Register ODBC driver on Mac OS. * [AD-506] * Write the private key file. * [AD-506] * Write the private key file. * [AD-506] * Don't fail build on comments. * [AD-506] * Copy code review to Mac OS build. * [AD-506] * Remove code review on Mac OS build. * [AD-506] * Attempt to make code review (checks.yml) non-failing. * [AD-506] * Mods for code review comments. * [AD-506] * Remove some warnings; Mac OS build improvements. * [AD-506] * Correct syntax error for Mac OS. * [AD-506] * Correct last line of ssh_config. * [AD-506] * Small improvements and removal of unused code. * [AD-506] * Small improvements. * [AD-506] * Changes for code review. * [AD-506] * Changes for code review. * [AD-506] * Set default JDBC_DRIVER_VERSION: "1.1.0". * [AD-506] * Improve MacOS build. * [AD-506] * Improve MacOS build. * [AD-506] * Improve MacOS build. * [AD-506] * Improve MacOS build. * [AD-506] * Improve MacOS build. * [AD-506] * Improve error handling.
    
  affonsov 
      pushed a commit
      that referenced
      this pull request
    
      Nov 17, 2022 
    
    
      
  
    
      
    
  
* simple query * Region is the key * log query result from Timestream * add Timestream types * remove credentials * roundtrip of query * working roundtrip simple query * cleanup * fix GitHub Action * move non-TS specific function to base class * revert the stack local variable ESResult es_result * add Timestream types Co-authored-by: Jerry Leung <jerryl@bitquilltech.com>
    
  affonsov 
      added a commit
      that referenced
      this pull request
    
      Nov 17, 2022 
    
    
      
  
    
      
    
  
* remove datum and timeseries datatype parser Co-authored-by: Bruce Irschick <brucei@bitquilltech.com>
    
  affonsov 
      pushed a commit
      that referenced
      this pull request
    
      Nov 17, 2022 
    
    
      
  
    
      
    
  
### Summary [AD-506] Reuse Apache Ignite JVM/JNI wrappers (examples) ### Description * Refactor existing Ignite JNI code into the ODBC project * Implement calls to use JNI to get a valid DocumentDB connection via JNI. * Get particular version of DocumentDB JDBC driver as part of build * Extend tests to include simple connection tests. TODO: * Setup secrets to allow connection to DocumentDB server via SSH tunnel * Enable MacOS build. ### Related Issue https://bitquill.atlassian.net/browse/AD-506 * [AD-506] Reuse Apache Ignite JVM/JNI wrappers (examples) * Refactor/copy from common to odbc project. * [AD-506] * Further refactor into odbc project. * [AD-506] * Add work to connect via JNI to DocumentDB JDBC driver. * [AD-506] * Correct build variables. * [AD-506] * Attempt correction for MacOS build * [AD-506] * Add registration of driver to workfow for windows. * [AD-506] * Correct declaration in connection.h. * [AD-506] * Correct initialization syntax error in MacOS build for java.cpp. * [AD-506] * Correct Linux/MacOS code for refactoring. * [AD-506] * Corrected driver registration. * [AD-506] * Add steps to run SSH tunnel. * [AD-506] * Remove flag to always run SSH tunnel. * [AD-506] * Fix registry and ssh tunnel. * [AD-506] * Fix ssh tunnel. * [AD-506] * Fix ssh tunnel. * [AD-506] * Fix ssh tunnel. * [AD-506] * Fix ssh tunnel. * [AD-506] * Fix ssh tunnel. * [AD-506] * Corrected driver registration. * [AD-506] * Change flags for SSH tunnel. * [AD-506] * Default known_hosts file. * [AD-506] * Default ssh config file. * [AD-506] * Disable external SSH tunnel - hard-code use of internal SSH tunnel - for now. * [AD-506] * Try register driver in windows 32-bit. * [AD-506] * Download JDBC driver for mac build. * [AD-506] * Download JDBC driver for mac build. * [AD-506] * Download JDBC driver for mac build. * [AD-506] * Download JDBC driver for mac build. * [AD-506] * Download JDBC driver for mac build. * [AD-506] * Download JDBC driver for mac build. * [AD-506] * Set the correct DOCUMENTDB_HOME. * [AD-506] * Make the build script exit on any error. * [AD-506] * Register ODBC driver on Mac OS. * [AD-506] * Write the private key file. * [AD-506] * Write the private key file. * [AD-506] * Don't fail build on comments. * [AD-506] * Copy code review to Mac OS build. * [AD-506] * Remove code review on Mac OS build. * [AD-506] * Attempt to make code review (checks.yml) non-failing. * [AD-506] * Mods for code review comments. * [AD-506] * Remove some warnings; Mac OS build improvements. * [AD-506] * Correct syntax error for Mac OS. * [AD-506] * Correct last line of ssh_config. * [AD-506] * Small improvements and removal of unused code. * [AD-506] * Small improvements. * [AD-506] * Changes for code review. * [AD-506] * Changes for code review. * [AD-506] * Set default JDBC_DRIVER_VERSION: "1.1.0". * [AD-506] * Improve MacOS build. * [AD-506] * Improve MacOS build. * [AD-506] * Improve MacOS build. * [AD-506] * Improve MacOS build. * [AD-506] * Improve MacOS build. * [AD-506] * Improve error handling.
    
  alexey-temnikov 
      pushed a commit
      that referenced
      this pull request
    
      Jan 14, 2023 
    
    
      
  
    
      
    
  
* simple query * Region is the key * log query result from Timestream * add Timestream types * remove credentials * roundtrip of query * working roundtrip simple query * cleanup * fix GitHub Action * move non-TS specific function to base class * revert the stack local variable ESResult es_result * add Timestream types Co-authored-by: Jerry Leung <jerryl@bitquilltech.com>
    
  alexey-temnikov 
      pushed a commit
      that referenced
      this pull request
    
      Jan 14, 2023 
    
    
      
  
    
      
    
  
* remove datum and timeseries datatype parser Co-authored-by: Bruce Irschick <brucei@bitquilltech.com>
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Summary
[AD-506] Reuse Apache Ignite JVM/JNI wrappers (examples)
Description
TODO:
Related Issue
https://bitquill.atlassian.net/browse/AD-506
Additional Reviewers
@affonsoBQ
@alexey-temnikov
@andiem-bq
@birschick-bq
@garya-bitquill